Add testcase for Go private repositories #2748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a2b095 to
a999d38
Compare
Signed-off-by: Matej Vašek <mvasek@redhat.com>
a999d38 to
88a8cbf
Compare
Contributor
Author
|
PTAL @lkingland |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
+ Coverage 62.33% 63.47% +1.13%
==========================================
Files 129 131 +2
Lines 15589 15598 +9
==========================================
+ Hits 9718 9901 +183
+ Misses 4941 4741 -200
- Partials 930 956 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lkingland
approved these changes
Mar 17, 2025
Member
lkingland
left a comment
There was a problem hiding this comment.
Looks good so far. It's disabled, so no risk of merging now and revisiting when the support is added
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 4, 2025
Signed-off-by: Matej Vašek <mvasek@redhat.com>
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 4, 2025
Signed-off-by: Matej Vašek <mvasek@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 4, 2025
* Fix http port 433 => 443 (knative#2742) * Trust loopback builders (knative#2750) Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add testcase for Go private repositories (knative#2748) Signed-off-by: Matej Vašek <mvasek@redhat.com> * Test adjustments (knative#2751) * Use tiny instead of base BP builder. * Decrease minimal required Go version. * Make the self-signed certificate CA==true so it works with update-ca-trust utility. Signed-off-by: Matej Vašek <mvasek@redhat.com> * Allow host mounts for build phahse (knative#2753) * Allow host mounts for build pahse. This is in particular useful for using paket bindings, e.g. to inject git credentials into build process. Signed-off-by: Matej Vašek <mvasek@redhat.com> * Mark test as a integration test Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: style Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Use s2i in standard mode, not "as-dockerfile" (knative#2764) Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * fixup cherry-pick The release-v1.16 branch uses older docker library version some minor adjusment was needed. Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Improvements for Go s2i assembler (knative#2765) * Return error code when compilation was not done * Run `go mod tidy` on scaffoded code Signed-off-by: Matej Vašek <mvasek@redhat.com> * S2I (source-to-image) host binds (knative#2766) * Added tests for s2i build with private Go module The test is for now skipped since host binds are not yet implemented for s2i. Signed-off-by: Matej Vašek <mvasek@redhat.com> * User "host" network mode for s2i build on Linux Signed-off-by: Matej Vašek <mvasek@redhat.com> * Implement host binds for local s2i build Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> * Make build binds more similar to runtime binds (knative#2768) * Make build binds more similar to runtime binds Signed-off-by: Matej Vašek <mvasek@redhat.com> * Added comments on struct Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Add guideline for private Go module usage (knative#2771) Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Fix: Go scaffolding uses correct module name (knative#2769) * Fix: Go scaffolding uses correct module name Using incorrect name works for a functions with flat structure -- no sub-packages. When sub-packages are used we need to refer the user module by its true name. Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup tests Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup for c841f40 Signed-off-by: Matej Vašek <matejvasek@gmail.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 3, 2025
picking knative#2748 Signed-off-by: Matej Vašek <mvasek@redhat.com>
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 6, 2025
* feat: remote storage class picking knative#2693 Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * Python Middleware v2 Scaffolding picking knative#2685 Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix Python S2I On-Cluster build picking knative#2770 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix http port 433 => 443 picking knative#2742 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Trust loopback builders picking knative#2750 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add testcase for Go private repositories picking knative#2748 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Test adjustments picking knative#2751 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Allow host mounts for build phahse picking knative#2753 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Use s2i in standard mode, not "as-dockerfile" picking knative#2764 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Improvements for Go s2i assembler picking knative#2765 Signed-off-by: Matej Vašek <mvasek@redhat.com> * S2I (source-to-image) host binds picking knative#2766 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Make build binds more similar to runtime binds picking knative#2768 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add guideline for private Go module usage picking knative#2771 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Improve Go templates README picking knative#2848 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix detection of hostname resolution failure picking knative#2841 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix: Go scaffolding uses correct module name picking knative#2769 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix non-containerized build/run /w external deps picking knative#2847 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Tekton 1.0.x fixes picking #1349 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix co-scheduling picking #1358 Co-authored-by: Jefferson Ramos <jeramos@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * test: fix gitlab test Signed-off-by: Matej Vašek <mvasek@redhat.com> * dapr install upgrade picking knative#3055 Co-authored-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: go.mod Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: update alpine version Signed-off-by: Matej Vašek <mvasek@redhat.com> * Migrate golangci-lint config to v2 picking knative#2781 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Bump golangci-lint version picking knative#2784 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix flaky unit test picking knative#2749 Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Luke Kingland <lkinglan@redhat.com> Co-authored-by: Jefferson Ramos <jeramos@redhat.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added tests that are skipped for now. The actual functionality will be added later.