[release-v.1.16] Cherry picks for v1.16 #1237
Conversation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
* Use tiny instead of base BP builder. * Decrease minimal required Go version. * Make the self-signed certificate CA==true so it works with update-ca-trust utility. Signed-off-by: Matej Vašek <mvasek@redhat.com>
* Allow host mounts for build pahse. This is in particular useful for using paket bindings, e.g. to inject git credentials into build process. Signed-off-by: Matej Vašek <mvasek@redhat.com> * Mark test as a integration test Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: style Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
The release-v1.16 branch uses older docker library version some minor adjusment was needed. Signed-off-by: Matej Vašek <matejvasek@gmail.com>
* Return error code when compilation was not done * Run `go mod tidy` on scaffoded code Signed-off-by: Matej Vašek <mvasek@redhat.com>
* Added tests for s2i build with private Go module The test is for now skipped since host binds are not yet implemented for s2i. Signed-off-by: Matej Vašek <mvasek@redhat.com> * User "host" network mode for s2i build on Linux Signed-off-by: Matej Vašek <mvasek@redhat.com> * Implement host binds for local s2i build Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com>
* Make build binds more similar to runtime binds Signed-off-by: Matej Vašek <mvasek@redhat.com> * Added comments on struct Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
* Fix: Go scaffolding uses correct module name Using incorrect name works for a functions with flat structure -- no sub-packages. When sub-packages are used we need to refer the user module by its true name. Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup tests Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com>
155baf3 to
d5c090d
Compare
|
New changes are detected. LGTM label has been removed. |
|
/test Konflux kflux-prd-rh02 / kn-plugin-func-func-util-116-on-pull-request |
|
@matejvasek: The specified target(s) for Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test "Konflux kflux-prd-rh02 / kn-plugin-func-func-util-116-on-pull-request" |
|
@matejvasek: The specified target(s) for Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Highlights
Feature: build host mounts -- users now can bind local file/directory into the build container. This can be for instance used for inserting
gitcredentials for privateGorepositories.Bugfix: fixed a bug where it was not possible to use external dependencies (non-Go stdlib) in
Gofunction.Bugfix: fixed scaffolding to use appropriate module name, this was causing troubles when using sub-modules in the
Gofunction.PRs picked