Skip to content

fix: python scaffolding #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Oct 13, 2025
Merged

fix: python scaffolding #3080

knative-prow merged 1 commit into from
Oct 13, 2025

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Oct 13, 2025 •
edited
Loading

Changes

  • fix: python scaffolding -- make "this function" dependency editable, otherwise only first build has effect any subsequent build "does nothing".

fixes: #3079

/kind bug

fix: Python pack build/run doesn't pick up code changes (#3079)

@matejvasek
fix: python scaffolding
3babcbf 
Make the function dependency "editable" by using develop=true.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2025
@knative-prow knative-prow bot requested a review from jrangelramos October 13, 2025 18:07
@knative-prow
Copy link

knative-prow bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from nainaz October 13, 2025 18:07
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@matejvasek matejvasek requested review from dprotaso and gauron99 and removed request for jrangelramos and nainaz October 13, 2025 18:08
@codecov
Copy link

codecov bot commented Oct 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.18%. Comparing base (d8525c2) to head (3babcbf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3080      +/-   ##
==========================================
+ Coverage   58.46%   59.18%   +0.72%     
==========================================
  Files         134      134              
  Lines       17251    17251              
==========================================
+ Hits        10085    10210     +125     
+ Misses       6234     6080     -154     
- Partials      932      961      +29
Flag Coverage Δ
e2e-tests 40.36% <ø> (+1.32%) ⬆️
integration-tests 53.90% <ø> (+1.62%) ⬆️
unit-tests 46.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor Author

matejvasek commented Oct 13, 2025

@dprotaso plz override unit-tests_func_main

@gauron99
Copy link
Contributor

gauron99 commented Oct 13, 2025

/override unit-tests_func_main

@knative-prow
Copy link

knative-prow bot commented Oct 13, 2025

@gauron99: Overrode contexts on behalf of gauron99: unit-tests_func_main

Details

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

dprotaso commented Oct 13, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@knative-prow knative-prow bot merged commit b8cc37a into knative:main Oct 13, 2025
39 checks passed
matejvasek added a commit to matejvasek/faas that referenced this pull request Oct 14, 2025
@matejvasek
fix: python scaffolding
87730ef 
picking knative#3080

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek mentioned this pull request Oct 14, 2025
Merged
matejvasek added a commit to matejvasek/faas that referenced this pull request Oct 14, 2025
@matejvasek
fix: python scaffolding
c1e7e67 
picking knative#3080

Signed-off-by: Matej Vašek <mvasek@redhat.com>
knative-prow bot pushed a commit that referenced this pull request Oct 14, 2025
@matejvasek @gauron99
Cherry picks 1.19 (#3089)
2988acf 
* Fix backward compat Python pack build

picking #2962

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: Python host builder base image version

picking #2965

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Remove container flag - variant I

picking #2987

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix python injector bug

picking #2992

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix-of-a-fix

picking #2994

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: python scaffolding

picking #3080

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: use python3 when python not presetn

picking #3082

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* dapr install upgrade

picking #3055

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

* test: skip ipv6 test correctly

picking #3076

Signed-off-by: Matej Vašek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

func build/run doesn't pick up code changes

3 participants

@matejvasek @gauron99 @dprotaso