Fix https port 433 => 443 #2742

matejvasek · 2025-03-12T03:59:12Z

No description provided.

github-actions · 2025-03-12T03:59:43Z

hack/allocate.sh

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

func/hack/allocate.sh

Line 94 in ecbe9ea

$KUBECTL apply --filename https://github.com/knative/serving/releases/download/knative-$knative_serving_version/serving-crds.yaml

github-actions · 2025-03-12T03:59:44Z

hack/allocate.sh

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

func/hack/allocate.sh

Line 99 in ecbe9ea

curl -L -s https://github.com/knative/serving/releases/download/knative-$knative_serving_version/serving-core.yaml | $KUBECTL apply -f -

github-actions · 2025-03-12T03:59:45Z

hack/allocate.sh

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

func/hack/allocate.sh

Line 191 in ecbe9ea

$KUBECTL apply -f https://github.com/knative/eventing/releases/download/knative-$knative_eventing_version/eventing-crds.yaml

github-actions · 2025-03-12T03:59:46Z

hack/allocate.sh

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

func/hack/allocate.sh

Line 196 in ecbe9ea

curl -L -s https://github.com/knative/eventing/releases/download/knative-$knative_eventing_version/eventing-core.yaml | $KUBECTL apply -f -

github-actions · 2025-03-12T03:59:47Z

hack/allocate.sh

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

func/hack/allocate.sh

Line 201 in ecbe9ea

curl -L -s https://github.com/knative/eventing/releases/download/knative-$knative_eventing_version/in-memory-channel.yaml | $KUBECTL apply -f -

github-actions · 2025-03-12T03:59:48Z

hack/allocate.sh

[shellcheck (suggestion)] _{reported by reviewdog 🐶}

func/hack/allocate.sh

Line 206 in ecbe9ea

curl -L -s https://github.com/knative/eventing/releases/download/knative-$knative_eventing_version/mt-channel-broker.yaml | $KUBECTL apply -f -

codecov · 2025-03-12T04:05:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.22%. Comparing base (180b1ee) to head (ecbe9ea).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (180b1ee) and HEAD (ecbe9ea). Click for more details.

HEAD has 6 uploads less than BASE

Flag BASE (180b1ee) HEAD (ecbe9ea)

unit-tests-ubuntu-latest 1 0

unit-tests-macos-latest 1 0

e2e-test 1 0

integration-tests 1 0

unit-tests-windows-latest 1 0

e2e-test-oncluster 1 0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2742       +/-   ##
===========================================
- Coverage   62.58%   49.22%   -13.37%     
===========================================
  Files         131      129        -2     
  Lines       15598    15589        -9     
===========================================
- Hits         9762     7673     -2089     
- Misses       4908     7212     +2304     
+ Partials      928      704      -224

Flag	Coverage Δ
e2e-test	`?`
e2e-test-oncluster	`?`
integration-tests	`?`
unit-tests-macos-latest	`?`
unit-tests-ubuntu-latest	`?`
unit-tests-windows-latest	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matejvasek · 2025-03-12T17:24:49Z

PTAL @gauron99 @lkingland @matzew

lkingland

/lgtm

matzew

/lgtm
/approve

/override codecov/project

knative-prow · 2025-03-14T06:19:46Z

@matzew: Overrode contexts on behalf of matzew: codecov/project

Details

In response to this:

/lgtm
/approve

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow · 2025-03-14T06:19:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lkingland,matejvasek,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Fix http port 433 => 443 (knative#2742) * Trust loopback builders (knative#2750) Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add testcase for Go private repositories (knative#2748) Signed-off-by: Matej Vašek <mvasek@redhat.com> * Test adjustments (knative#2751) * Use tiny instead of base BP builder. * Decrease minimal required Go version. * Make the self-signed certificate CA==true so it works with update-ca-trust utility. Signed-off-by: Matej Vašek <mvasek@redhat.com> * Allow host mounts for build phahse (knative#2753) * Allow host mounts for build pahse. This is in particular useful for using paket bindings, e.g. to inject git credentials into build process. Signed-off-by: Matej Vašek <mvasek@redhat.com> * Mark test as a integration test Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: style Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Use s2i in standard mode, not "as-dockerfile" (knative#2764) Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * fixup cherry-pick The release-v1.16 branch uses older docker library version some minor adjusment was needed. Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Improvements for Go s2i assembler (knative#2765) * Return error code when compilation was not done * Run `go mod tidy` on scaffoded code Signed-off-by: Matej Vašek <mvasek@redhat.com> * S2I (source-to-image) host binds (knative#2766) * Added tests for s2i build with private Go module The test is for now skipped since host binds are not yet implemented for s2i. Signed-off-by: Matej Vašek <mvasek@redhat.com> * User "host" network mode for s2i build on Linux Signed-off-by: Matej Vašek <mvasek@redhat.com> * Implement host binds for local s2i build Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> * Make build binds more similar to runtime binds (knative#2768) * Make build binds more similar to runtime binds Signed-off-by: Matej Vašek <mvasek@redhat.com> * Added comments on struct Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Add guideline for private Go module usage (knative#2771) Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com> * Fix: Go scaffolding uses correct module name (knative#2769) * Fix: Go scaffolding uses correct module name Using incorrect name works for a functions with flat structure -- no sub-packages. When sub-packages are used we need to refer the user module by its true name. Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup tests Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup for c841f40 Signed-off-by: Matej Vašek <matejvasek@gmail.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>

picking knative#2742 Signed-off-by: Matej Vašek <mvasek@redhat.com>

* feat: remote storage class picking knative#2693 Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * Python Middleware v2 Scaffolding picking knative#2685 Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix Python S2I On-Cluster build picking knative#2770 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix http port 433 => 443 picking knative#2742 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Trust loopback builders picking knative#2750 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add testcase for Go private repositories picking knative#2748 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Test adjustments picking knative#2751 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Allow host mounts for build phahse picking knative#2753 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Use s2i in standard mode, not "as-dockerfile" picking knative#2764 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Improvements for Go s2i assembler picking knative#2765 Signed-off-by: Matej Vašek <mvasek@redhat.com> * S2I (source-to-image) host binds picking knative#2766 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Make build binds more similar to runtime binds picking knative#2768 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Add guideline for private Go module usage picking knative#2771 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Improve Go templates README picking knative#2848 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix detection of hostname resolution failure picking knative#2841 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix: Go scaffolding uses correct module name picking knative#2769 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix non-containerized build/run /w external deps picking knative#2847 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Tekton 1.0.x fixes picking #1349 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Fix co-scheduling picking #1358 Co-authored-by: Jefferson Ramos <jeramos@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * test: fix gitlab test Signed-off-by: Matej Vašek <mvasek@redhat.com> * dapr install upgrade picking knative#3055 Co-authored-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Luke Kingland <lkinglan@redhat.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: go.mod Signed-off-by: Matej Vašek <mvasek@redhat.com> * fixup: update alpine version Signed-off-by: Matej Vašek <mvasek@redhat.com> * Migrate golangci-lint config to v2 picking knative#2781 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Bump golangci-lint version picking knative#2784 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix flaky unit test picking knative#2749 Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: Luke Kingland <lkinglan@redhat.com> Co-authored-by: Jefferson Ramos <jeramos@redhat.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com>

Fix http port 433 => 443

ecbe9ea

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025

knative-prow bot requested review from dsimansk and jrangelramos March 12, 2025 03:59

knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2025

matejvasek requested review from gauron99, lkingland and matzew and removed request for dsimansk and jrangelramos March 12, 2025 03:59

matejvasek changed the title ~~Fix http port 433 => 443~~ Fix https port 433 => 443 Mar 12, 2025

github-actions bot reviewed Mar 12, 2025

View reviewed changes

lkingland approved these changes Mar 13, 2025

View reviewed changes

knative-prow bot assigned lkingland Mar 13, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025

matzew approved these changes Mar 14, 2025

View reviewed changes

knative-prow bot assigned matzew Mar 14, 2025

knative-prow bot merged commit a351afd into main Mar 14, 2025
35 of 36 checks passed

matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Apr 4, 2025

Fix http port 433 => 443 (knative#2742)

4eb1814

matejvasek mentioned this pull request Apr 4, 2025

[release-v.1.16] Cherry picks for v1.16 openshift-knative/kn-plugin-func#1237

Merged

matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Apr 4, 2025

Fix http port 433 => 443 (knative#2742)

cb38571

matejvasek added a commit to openshift-knative/kn-plugin-func that referenced this pull request Oct 3, 2025

Fix http port 433 => 443

00f6134

picking knative#2742 Signed-off-by: Matej Vašek <mvasek@redhat.com>

matejvasek mentioned this pull request Oct 3, 2025

[release-v1.17] Backports openshift-knative/kn-plugin-func#1366

Merged

matejvasek deleted the matejvasek-patch-1 branch December 16, 2025 10:27

Fix https port 433 => 443 #2742

Fix https port 433 => 443 #2742

Uh oh!

Conversation

matejvasek commented Mar 12, 2025

Uh oh!

github-actions bot Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

matejvasek commented Mar 12, 2025

Uh oh!

lkingland left a comment

Choose a reason for hiding this comment

Uh oh!

matzew left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow bot commented Mar 14, 2025

Uh oh!

knative-prow bot commented Mar 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Mar 12, 2025 •

edited

Loading