Correct latent single instance lock file preventing launch#997
Merged
droidmonkey merged 1 commit intorelease/2.2.1from Sep 27, 2017
Merged
Correct latent single instance lock file preventing launch#997droidmonkey merged 1 commit intorelease/2.2.1from
droidmonkey merged 1 commit intorelease/2.2.1from
Conversation
louib
reviewed
Sep 26, 2017
| if (!m_alreadyRunning) { | ||
| // If we get here then the original instance is likely dead | ||
| // forceably reset the lock file | ||
| m_lockFile->removeStaleLockFile(); |
Member
There was a problem hiding this comment.
@droidmonkey Maybe we could add a qDebug or qWarn here? Might be useful for debugging purposes.
Member
Author
There was a problem hiding this comment.
Good idea, I'll add that tonight
louib
approved these changes
Sep 26, 2017
793dc70 to
2b69b40
Compare
louib
approved these changes
Sep 27, 2017
TheZ3ro
approved these changes
Sep 27, 2017
Contributor
TheZ3ro
left a comment
There was a problem hiding this comment.
Seems fine and works great.
Any specific reason to use + instead of .append for strings?
Member
Author
|
Consistency in the code and i think it reads better. Bouncing between Kotlin and C++ I can never remember what is immutable and what isn't. |
droidmonkey
added a commit
that referenced
this pull request
Oct 1, 2017
- Corrected multiple snap issues [#934, #1011] - Corrected multiple custom icon issues [#708, #719, #994] - Corrected multiple Yubikey issues [#880] - Fixed single instance preventing load on occasion [#997] - Keep entry history when merging databases [#970] - Prevent data loss if passwords were mismatched [#1007] - Fixed crash after merge [#941] - Added configurable auto-type default delay [#703] - Unlock database dialog window comes to front [#663] - Translation and compiling fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I also took the opportunity to bring this code into alignment with the coding standards for variable naming.
Motivation and context
This issue has been reported 4 times since release of 2.2.0.
How has this been tested?
Manually
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]