Make favicon Google fallback optional and off by default#708
Merged
phoerious merged 1 commit intorelease/2.2.1from Jun 28, 2017
Merged
Make favicon Google fallback optional and off by default#708phoerious merged 1 commit intorelease/2.2.1from
phoerious merged 1 commit intorelease/2.2.1from
Conversation
weslly
approved these changes
Jun 28, 2017
droidmonkey
added a commit
that referenced
this pull request
Oct 1, 2017
- Corrected multiple snap issues [#934, #1011] - Corrected multiple custom icon issues [#708, #719, #994] - Corrected multiple Yubikey issues [#880] - Fixed single instance preventing load on occasion [#997] - Keep entry history when merging databases [#970] - Prevent data loss if passwords were mismatched [#1007] - Fixed crash after merge [#941] - Added configurable auto-type default delay [#703] - Unlock database dialog window comes to front [#663] - Translation and compiling fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch makes the Google fallback for downloading website favicons optional and off by default.
Motivation and context
Privacy concerns have been raised.
How has this been tested?
Tried to download favicon for example.com. Without the option ticked, download fails and an error message is shown. With the option ticked, the Google default favicon is downloaded.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]