Skip to content

Correct multiple snap issues#934

Merged
TheZ3ro merged 1 commit intorelease/2.2.1from
hotfix/snap
Sep 19, 2017
Merged

Correct multiple snap issues#934
TheZ3ro merged 1 commit intorelease/2.2.1from
hotfix/snap

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

@droidmonkey droidmonkey commented Sep 10, 2017 •
edited
Loading

Description

Provide fixes to multiple snap issues reported.

Note: In order to use Yubikey you must manually connect the raw-usb interface using: sudo snap connect keepassxc:raw-usb core:raw-usb

How has this been tested?

Manually and unit tests.

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@droidmonkey droidmonkey added this to the v2.2.1 milestone Sep 10, 2017
@droidmonkey droidmonkey changed the base branch from develop to release/2.2.1 September 10, 2017 14:27
@TheZ3ro
Copy link
Copy Markdown
Contributor

TheZ3ro commented Sep 10, 2017

Note: In order to use Yubikey you must manually connect the raw-usb interface using: sudo snap connect keepassxc:raw-usb core:raw-usb

This needs to go in the documentation and in the FAQ page on the website.

@droidmonkey
Copy link
Copy Markdown
Member Author

droidmonkey commented Sep 10, 2017 •
edited
Loading

Btw, it looks like the new travis image causes asan to blow up.

@louib
Copy link
Copy Markdown
Member

louib commented Sep 16, 2017

@droidmonkey the travis build should be passing if you rebase on release/2.2.1

@TheZ3ro TheZ3ro merged commit daef0a3 into release/2.2.1 Sep 19, 2017
@TheZ3ro TheZ3ro deleted the hotfix/snap branch September 19, 2017 11:29
droidmonkey added a commit that referenced this pull request Oct 1, 2017
@droidmonkey
Release 2.2.1
2bce9c8 
- Corrected multiple snap issues [#934, #1011]
- Corrected multiple custom icon issues [#708, #719, #994]
- Corrected multiple Yubikey issues [#880]
- Fixed single instance preventing load on occasion [#997]
- Keep entry history when merging databases [#970]
- Prevent data loss if passwords were mismatched [#1007]
- Fixed crash after merge [#941]
- Added configurable auto-type default delay [#703]
- Unlock database dialog window comes to front [#663]
- Translation and compiling fixes
@josechrist
Copy link
Copy Markdown

josechrist commented Nov 16, 2017 •
edited
Loading

Command line:
It would be nice to have similar options than keepass, that is
keepass <db_URL> -keyfile:<path_to_file> -iousername:<username> -iopassword:<password> -ioscomplete -minimize
However, it would be much better to have -iousername:<path_to_file>
where file contains "username passwd" to hide username and passwd from process details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louib louib louib approved these changes

@phoerious phoerious Awaiting requested review from phoerious

+1 more reviewer

@TheZ3ro TheZ3ro TheZ3ro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distribution

Projects

None yet

Milestone

v2.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@droidmonkey @TheZ3ro @louib @josechrist