Skip to content

Implement configurable default auto-type delay (fixes #699)#703

Merged
phoerious merged 3 commits intokeepassxreboot:release/2.2.1from
hifi:autotype-delay-override
Jun 29, 2017
Merged

Implement configurable default auto-type delay (fixes #699)#703
phoerious merged 3 commits intokeepassxreboot:release/2.2.1from
hifi:autotype-delay-override

Conversation

@hifi
Copy link
Copy Markdown
Contributor

@hifi hifi commented Jun 28, 2017 •
edited
Loading

Adds both solutions presented in issue #699.

Description

All platform dependant hardcoded auto-type delays were removed in favor of a configurable default. UI was added to configure the delay which defaults to 25ms as specified.

Motivation and context

Issue #699.

How has this been tested?

Only on Linux with three different auto-type entries:

  1. Default, no custom delay (will use the configured default)
  2. Sequence with {DELAY=0} -> will override the default
  3. Sequence with {DELAY=200} -> will override the default

Tested the default at 0 ms, 25 ms and 500 ms. All work and are overridable by the sequence {DELAY=X} option.

Screenshots (if appropriate):

image

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✅ New feature (non-breaking change which adds functionality)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]

phoerious
phoerious requested changes Jun 28, 2017
View reviewed changes
src/gui/SettingsWidgetGeneral.ui Outdated
</property>
</widget>
</item>
<item>
Copy link
Copy Markdown
Member

@phoerious phoerious Jun 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a proper grid layout. One column for the labels (aligned right) and one column for the input widgets.

Copy link
Copy Markdown
Contributor Author

@hifi hifi Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the global auto-type shortcut was already hacked together like this so I just continued the tradition. Just to clarify: you want me to wrap both of them in a grid like "Timeouts" is in "Security"?

Copy link
Copy Markdown
Member

@phoerious phoerious Jun 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have one because it's the only option like that on this tab. But as soon as you have two or more, you need a grid to align them. So yes, please wrap those two options in a grid.

@phoerious phoerious changed the base branch from develop to release/2.2.1 June 29, 2017 01:19
@phoerious
Copy link
Copy Markdown
Member

phoerious commented Jun 29, 2017

After addressing my review change request, please replay your changes on top of release/2.2.1 instead of develop (you can re-use the same branch by force-pushing, so we don't need a new PR).

@phoerious phoerious added this to the v2.2.1 milestone Jun 29, 2017
@hifi
Make default auto-type delay of 25ms overridable with {DELAY=X}
7e740b3 
Additionally this fixes the increased delay when you had your own
custom delay configured and it always added 25ms on top of it.
@hifi hifi force-pushed the autotype-delay-override branch from 121ca17 to 10e78d9 Compare June 29, 2017 13:47
@hifi
Copy link
Copy Markdown
Contributor Author

hifi commented Jun 29, 2017

Changed to grid layout and rebased against release/2.2.1.

image

@phoerious
Copy link
Copy Markdown
Member

phoerious commented Jun 29, 2017 •
edited
Loading

Thanks for your adjustments. Only thing missing: the two labels need to be right-aligned and you may not want to stretch the time field all the way to the right.

@hifi hifi force-pushed the autotype-delay-override branch from 10e78d9 to 933ccce Compare June 29, 2017 17:50
@hifi
Copy link
Copy Markdown
Contributor Author

hifi commented Jun 29, 2017

Sorry, my oversight. Fixed now.

image

@hifi hifi force-pushed the autotype-delay-override branch from 933ccce to a032945 Compare June 29, 2017 17:59
@hifi
Copy link
Copy Markdown
Contributor Author

hifi commented Jun 29, 2017

image

@phoerious phoerious merged commit e53ac65 into keepassxreboot:release/2.2.1 Jun 29, 2017
@adatum
Copy link
Copy Markdown

adatum commented Sep 12, 2017

Any chance of another release soon with the many changes committed and merged so far? In particular, this feature of a configurable delay (or no delay, as in versions prior to v2.2.0) has a big impact on usability with long passwords.

@adatum adatum mentioned this pull request Sep 14, 2017
Closed
@droidmonkey droidmonkey mentioned this pull request Sep 25, 2017
Closed
droidmonkey added a commit that referenced this pull request Oct 1, 2017
@droidmonkey
Release 2.2.1
2bce9c8 
- Corrected multiple snap issues [#934, #1011]
- Corrected multiple custom icon issues [#708, #719, #994]
- Corrected multiple Yubikey issues [#880]
- Fixed single instance preventing load on occasion [#997]
- Keep entry history when merging databases [#970]
- Prevent data loss if passwords were mismatched [#1007]
- Fixed crash after merge [#941]
- Added configurable auto-type default delay [#703]
- Unlock database dialog window comes to front [#663]
- Translation and compiling fixes
@phoerious phoerious added pr: new feature Pull request adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phoerious phoerious phoerious approved these changes

Assignees

No one assigned

Labels

pr: new feature Pull request adds a new feature

Projects

None yet

Milestone

v2.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@hifi @phoerious @adatum