Allow groups to restrict by browser integration key (#6437)#9852
Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom Jan 14, 2024
Merged
Allow groups to restrict by browser integration key (#6437)#9852droidmonkey merged 1 commit intokeepassxreboot:developfrom
droidmonkey merged 1 commit intokeepassxreboot:developfrom
Conversation
42fbf09 to
cdcea83
Compare
2b64b4e to
6ffdaf2
Compare
Contributor
Author
|
@droidmonkey I don't understand the codecov/patch failure--what do I need to do to fix that? |
Member
|
We set an ideal threshold for new code introduced to be 75% covered by unit tests. It's optional though. |
Contributor
Author
|
Thanks. I tried increasing the test coverage but couldn't find a clear path given that some of the parent functions in BrowserService aren't tested. How do I request a code review? |
Member
|
Could you solve the conflicts? Rebase the branch. |
6ffdaf2 to
3bf086e
Compare
Contributor
Author
|
Rebase complete |
Member
|
Some of the code could be cleaned a little bit. For example:
|
3bf086e to
453b2d0
Compare
Contributor
Author
|
Thanks for the fast response! I think I caught them all, but let me know if there's anything else. I couldn't return {} in BroswerService.cpp:996 because I got a compiler error returning an initializer list from that lambda function. |
varjolintu
reviewed
Oct 31, 2023
453b2d0 to
a5d3cbb
Compare
Member
|
Tested this, and it works nicely. Only thing that caught my eye is the strange separator in the combobox: When looking at other comboboxes, the separators look much more smaller: |
Contributor
Author
|
Interesting. I think that's because the screenshot above is actually referencing a QMenu not a ComboBox (see EditWidgetIcons.cpp:170). |
varjolintu
approved these changes
Nov 4, 2023
Member
varjolintu
left a comment
There was a problem hiding this comment.
Approved. We are missing a combobox separator style, but the scope is outside of this PR.
Contributor
Author
|
Anything else I need to do to get approval on this? |
Contributor
Author
|
bump |
Member
Bump? This PR is already accepted. |
a5d3cbb to
2696a0a
Compare
Contributor
Author
|
Going to need some help here. There was a merge conflict so I resolved that but now one of the unit tests is failing and I'm not sure why. (It seems unrelated) |
Member
|
You can ignore, we have sporadic failures since some tests rely on randomness and infrequently don't produce the expected results. |
Contributor
Author
|
Since I'm not familiar with the development cadence for this project, what is the typical timeline/workflow between approval, review, and merge? |
Member
|
I will merge it in when I get the chance. Unfortunately my time is very limited lately. |
bc63076 to
d808596
Compare
dragonekii
pushed a commit
to dragonekii/keepassxc-custom
that referenced
this pull request
Dec 8, 2025
Release 2.7.11 (2025-11-23) - Add image, HTML, Markdown preview, and text editing support to inline attachment viewer [keepassxreboot#12085, keepassxreboot#12244, keepassxreboot#12654] - Add database merge confirmation dialog [keepassxreboot#10173] - Add option to auto-generate a password for new entries [keepassxreboot#12593] - Add support for group sync in KeeShare [keepassxreboot#11593] - Add {UUID} placeholder for use in references [keepassxreboot#12511] - Add “Wait for Enter” search option [keepassxreboot#12263] - Add keyboard shortcut to “Jump to Group” from search results [keepassxreboot#12225] - Add predefined search for TOTP entries [keepassxreboot#12199] - Add confirmation when closing database via ESC key [keepassxreboot#11963] - Add support for escaping placeholder expressions [keepassxreboot#11904] - Reduce tab indentation width in notes fields [keepassxreboot#11919] - Cap default Argon2 parallelism when creating a new database [keepassxreboot#11853] - Database lock after inactivity now enabled by default and set to 900 seconds [keepassxreboot#12689, keepassxreboot#12609] - Copying TOTP now opens setup dialog if none is configured for entry [keepassxreboot#12584] - Make double click action configurable [keepassxreboot#12322] - Remove unused “Last Accessed” from GUI [keepassxreboot#12602] - Auto-Type: Add more granular confirmation settings [keepassxreboot#12370] - Auto-Type: Add URL typing preset and add copy options to menu [keepassxreboot#12341] - Browser: Do not allow sites automatically if entry added from browser extension [keepassxreboot#12413] - Browser: Add options to restrict exposed groups [keepassxreboot#9852, keepassxreboot#12119] - Bitwarden Import: Add support for timestamps and password history [keepassxreboot#12588] - macOS: Add Liquid Glass icon [keepassxreboot#12642] - macOS: Remove theme-based menubar icon toggle [keepassxreboot#12685] - macOS: Add Window and Help menus [keepassxreboot#12357] - Windows: Add option to add KeePassXC to PATH during installation [keepassxreboot#12171] - Fix window geometry not being restored properly when KeePassXC starts in tray [keepassxreboot#12683] - Fix potential database truncation when using direct write save method with YubiKeys [keepassxreboot#11841] - Fix issue with database backup saving [keepassxreboot#11874] - Fix UI lockups during startup with multiple tabs [keepassxreboot#12053] - Fix keyboard shortcuts when menubar is hidden [keepassxreboot#12431] - Fix clipboard being cleared on exit even if no password was copied [keepassxreboot#12603] - Fix single-instance detection when username contains invalid filename characters [keepassxreboot#12559] - Fix “Search Wait for Enter” setting not being save [keepassxreboot#12614] - Fix hotkey accelerators not being escaped properly on database tabs [keepassxreboot#12630] - Fix confusing error if user cancels out of key file edit dialog [keepassxreboot#12639] - Fix issues with saved searches and “Press Enter to Search” option [keepassxreboot#12314] - Fix URL wildcard matching [keepassxreboot#12257] - Fix TOTP visibility on unlock and settings change [keepassxreboot#12220] - Fix KeeShare entries with reference attributes not updating [keepassxreboot#11809] - Fix sort order not being maintained when toggling filters in database reports [keepassxreboot#11849] - Fix several UI font and layout issues [keepassxreboot#11967, keepassxreboot#12102] - Prevent mouse wheel scroll on edit username field [keepassxreboot#12398] - Improve base translation consistency [keepassxreboot#12432] - Improve inactivity timer [keepassxreboot#12246] - Documentation improvements [keepassxreboot#12373, keepassxreboot#12506] - Browser: Fix ordering of clientDataJSON in Passkey response object [keepassxreboot#12120] - Browser: Fix URL matching for additional URLs [keepassxreboot#12196] - Browser: Fix group settings inheritance [keepassxreboot#12368] - Browser: Allow read-only native messaging config files [keepassxreboot#12236] - Browser: Optimise entry iteration in browser access control dialog [keepassxreboot#11817] - Browser: Fix “Do not ask permission for HTTP Basic Auth” option [keepassxreboot#11871] - Browser: Fix native messaging path for Tor Browser launcher on Linux [keepassxreboot#12005] - Auto-Type: Fix empty window behaviour [keepassxreboot#12622] - Auto-Type: Take delays into account when typing TOTP [keepassxreboot#12691] - SSH Agent: Fix out-of-memory crash with malformed SSH keys [keepassxreboot#12606] - CSV Import: Fix modified and creation time import [keepassxreboot#12379] - CSV Import: Fix duplication of root groups on import [keepassxreboot#12240] - Proton Pass Import: Fix email addresses not being imported when no username set [keepassxreboot#11888] - macOS: Fix secure input getting stuck [keepassxreboot#11928] - Windows: Prevent launch as SYSTEM user from MSI installer [keepassxreboot#12705] - Windows: Remove broken check for MSVC Redistributable from MSI installer [keepassxreboot#11950] - Linux: Fix startup delay due to StartupNotify setting in desktop file [keepassxreboot#12306] - Linux: Fix memory initialisation when --pw-stdin is used with a pipe [keepassxreboot#12050]
|
This option is very useful but it wasn't included in 2.7.11 as well. |
Contributor
Author
|
I'm using the Fedora stock 2.7.11 build and the "Restrict matching to given
browser key" is present and functional. (See attached screenshot)[image:
image.png]
…On Wed, Jan 7, 2026 at 2:37 PM Yuriy Kulikov ***@***.***> wrote:
*yoris* left a comment (keepassxreboot/keepassxc#9852)
<#9852 (comment)>
This option is very useful but it wasn't included in 2.7.11 as well.
—
Reply to this email directly, view it on GitHub
<#9852 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACELVYRPWKTSLLPW2WO7KWT4FV4B7AVCNFSM6AAAAACQ7Y7YYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMRQHEYTKOJUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
All looks good—the option exists. Apologies—I was searching in the incorrect section of the UI settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to issue #6437
This branch adds the ability to set a browser restriction on groups. This allows a given group tree to be visible only to a specific browser. Previously, the workaround was to have separate databases for each browser. However, this can become cumbersome under situations where someone may have a dozen or more browsers that each have to be unlocked whenever the screensaver activates.
Screenshots
Testing strategy
Type of change