Skip to content

Fix Keeshare Entries with Reference Attributes not updating#11809

Merged
droidmonkey merged 2 commits intokeepassxreboot:developfrom
MNarath1:fix/referenceresolvekeeshare
Nov 2, 2025
Merged

Fix Keeshare Entries with Reference Attributes not updating#11809
droidmonkey merged 2 commits intokeepassxreboot:developfrom
MNarath1:fix/referenceresolvekeeshare

Conversation

@MNarath1
Copy link
Copy Markdown
Contributor

@MNarath1 MNarath1 commented Mar 3, 2025

A Entry that gets shared containing a reference Attribute would not write a history entry upon resolving said Attribute resulting in the import into the target database not beeing triggered despite the changes beeing written to the keeshare db.
Fixes #10356
Fixes #7282
I will put this as a nonbreaking change since this should not influence any keeshares made without a reference Attribute in an entry.

Screenshots

Original Entry
image
Target Db Entry
image

Testing strategy

Test Performed on both windows and linux

  1. Created 2 DB 1 for exporting a keeshare and 1 for importing a keeshare
  2. Created 1 entry at the root of the first db and clone it with references and put the clone into its own folder that then gets exported as a keeshare db.
  3. import said keeshare into the second db
  4. change the Password attribute of the first entry created in the root folder of Database 1
  5. check in Database 2 if the changes get reflected

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

MNarath1 added 2 commits March 3, 2025 14:51
-- A Entry that gets shared containing a reference Attribute would not write a history entry upon resolving said Attribute resulting in the import into the target database not beeing triggered despite the changes beeing written to the keeshare db.
--beginUpdate() and endUpdate() already contain setUpdateTimeinfo so having it in the resolveReferenceAttributes() function makes it redundant and could potentially lead to issues.
@MNarath1 MNarath1 changed the title Fix Keeshare Entries with Refernce Attributes not updating upon change of the Attribute in the Original Entry Fix Keeshare Entries with Reference Attributes not updating upon change of the Attribute in the Original Entry Mar 3, 2025
@MNarath1 MNarath1 changed the title Fix Keeshare Entries with Reference Attributes not updating upon change of the Attribute in the Original Entry Fix Keeshare Entries with Reference Attributes not updating May 28, 2025
@droidmonkey droidmonkey added this to the v2.7.11 milestone Nov 2, 2025
@droidmonkey droidmonkey merged commit a709f14 into keepassxreboot:develop Nov 2, 2025
11 checks passed
droidmonkey pushed a commit that referenced this pull request Nov 2, 2025
A Entry that gets shared containing a reference Attribute would not write a history entry upon resolving said Attribute resulting in the import into the target database not beeing triggered despite the changes beeing written to the keeshare db.
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Nov 2, 2025
dragonekii pushed a commit to dragonekii/keepassxc-custom that referenced this pull request Dec 8, 2025
Release 2.7.11 (2025-11-23)

- Add image, HTML, Markdown preview, and text editing support to inline attachment viewer [keepassxreboot#12085, keepassxreboot#12244, keepassxreboot#12654]
- Add database merge confirmation dialog [keepassxreboot#10173]
- Add option to auto-generate a password for new entries [keepassxreboot#12593]
- Add support for group sync in KeeShare [keepassxreboot#11593]
- Add {UUID} placeholder for use in references [keepassxreboot#12511]
- Add “Wait for Enter” search option [keepassxreboot#12263]
- Add keyboard shortcut to “Jump to Group” from search results [keepassxreboot#12225]
- Add predefined search for TOTP entries [keepassxreboot#12199]
- Add confirmation when closing database via ESC key [keepassxreboot#11963]
- Add support for escaping placeholder expressions [keepassxreboot#11904]
- Reduce tab indentation width in notes fields [keepassxreboot#11919]
- Cap default Argon2 parallelism when creating a new database [keepassxreboot#11853]
- Database lock after inactivity now enabled by default and set to 900 seconds [keepassxreboot#12689, keepassxreboot#12609]
- Copying TOTP now opens setup dialog if none is configured for entry [keepassxreboot#12584]
- Make double click action configurable [keepassxreboot#12322]
- Remove unused “Last Accessed” from GUI [keepassxreboot#12602]
- Auto-Type: Add more granular confirmation settings [keepassxreboot#12370]
- Auto-Type: Add URL typing preset and add copy options to menu [keepassxreboot#12341]
- Browser: Do not allow sites automatically if entry added from browser extension [keepassxreboot#12413]
- Browser: Add options to restrict exposed groups [keepassxreboot#9852, keepassxreboot#12119]
- Bitwarden Import: Add support for timestamps and password history [keepassxreboot#12588]
- macOS: Add Liquid Glass icon [keepassxreboot#12642]
- macOS: Remove theme-based menubar icon toggle [keepassxreboot#12685]
- macOS: Add Window and Help menus [keepassxreboot#12357]
- Windows: Add option to add KeePassXC to PATH during installation [keepassxreboot#12171]

- Fix window geometry not being restored properly when KeePassXC starts in tray [keepassxreboot#12683]
- Fix potential database truncation when using direct write save method with YubiKeys [keepassxreboot#11841]
- Fix issue with database backup saving [keepassxreboot#11874]
- Fix UI lockups during startup with multiple tabs [keepassxreboot#12053]
- Fix keyboard shortcuts when menubar is hidden [keepassxreboot#12431]
- Fix clipboard being cleared on exit even if no password was copied [keepassxreboot#12603]
- Fix single-instance detection when username contains invalid filename characters [keepassxreboot#12559]
- Fix “Search Wait for Enter” setting not being save [keepassxreboot#12614]
- Fix hotkey accelerators not being escaped properly on database tabs [keepassxreboot#12630]
- Fix confusing error if user cancels out of key file edit dialog [keepassxreboot#12639]
- Fix issues with saved searches and “Press Enter to Search” option [keepassxreboot#12314]
- Fix URL wildcard matching [keepassxreboot#12257]
- Fix TOTP visibility on unlock and settings change [keepassxreboot#12220]
- Fix KeeShare entries with reference attributes not updating [keepassxreboot#11809]
- Fix sort order not being maintained when toggling filters in database reports [keepassxreboot#11849]
- Fix several UI font and layout issues [keepassxreboot#11967,  keepassxreboot#12102]
- Prevent mouse wheel scroll on edit username field [keepassxreboot#12398]
- Improve base translation consistency [keepassxreboot#12432]
- Improve inactivity timer [keepassxreboot#12246]
- Documentation improvements [keepassxreboot#12373, keepassxreboot#12506]
- Browser: Fix ordering of clientDataJSON in Passkey response object [keepassxreboot#12120]
- Browser: Fix URL matching for additional URLs [keepassxreboot#12196]
- Browser: Fix group settings inheritance [keepassxreboot#12368]
- Browser: Allow read-only native messaging config files [keepassxreboot#12236]
- Browser: Optimise entry iteration in browser access control dialog [keepassxreboot#11817]
- Browser: Fix “Do not ask permission for HTTP Basic Auth” option [keepassxreboot#11871]
- Browser: Fix native messaging path for Tor Browser launcher on Linux [keepassxreboot#12005]
- Auto-Type: Fix empty window behaviour [keepassxreboot#12622]
- Auto-Type: Take delays into account when typing TOTP [keepassxreboot#12691]
- SSH Agent: Fix out-of-memory crash with malformed SSH keys [keepassxreboot#12606]
- CSV Import: Fix modified and creation time import [keepassxreboot#12379]
- CSV Import: Fix duplication of root groups on import [keepassxreboot#12240]
- Proton Pass Import: Fix email addresses not being imported when no username set [keepassxreboot#11888]
- macOS: Fix secure input getting stuck [keepassxreboot#11928]
- Windows: Prevent launch as SYSTEM user from MSI installer [keepassxreboot#12705]
- Windows: Remove broken check for MSVC Redistributable from MSI installer [keepassxreboot#11950]
- Linux: Fix startup delay due to StartupNotify setting in desktop file [keepassxreboot#12306]
- Linux: Fix memory initialisation when --pw-stdin is used with a pipe [keepassxreboot#12050]
hannpet pushed a commit to hannpet/keepassxc that referenced this pull request Jan 2, 2026
A Entry that gets shared containing a reference Attribute would not write a history entry upon resolving said Attribute resulting in the import into the target database not beeing triggered despite the changes beeing written to the keeshare db.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: KeeShare pr: backported Pull request backported to previous release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keeshare does not synchronize referenced fields of clones KeeShare writing caused by references

2 participants