🐛 Fix result propagation in SymmetricCipherGcrypt::process#1099
Merged
phoerious merged 2 commits intokeepassxreboot:release/2.2.2from Oct 21, 2017
petermax2:release/2.2.2
Merged
🐛 Fix result propagation in SymmetricCipherGcrypt::process#1099phoerious merged 2 commits intokeepassxreboot:release/2.2.2from petermax2:release/2.2.2
phoerious merged 2 commits intokeepassxreboot:release/2.2.2from
petermax2:release/2.2.2
Conversation
The boolean 'ok' has always been set to true, regardless of possible errors.
phoerious
approved these changes
Oct 21, 2017
phoerious
added a commit
that referenced
this pull request
Oct 21, 2017
- Fixed entries with empty URLs being reported to KeePassHTTP clients [#1031] - Fixed YubiKey detection and enabled CLI tool for AppImage binary [#1100] - Added AppStream description [#1082] - Improved TOTP compatibility and added new Base32 implementation [#1069] - Fixed error handling when processing invalid cipher stream [#1099] - Fixed double warning display when opening a database [#1037] - Fixed unlocking databases with --pw-stdin [#1087] - Added ability to override QT_PLUGIN_PATH environment variable for AppImages [#1079] - Fixed transform seed not being regenerated when saving the database [#1068] - Fixed only one YubiKey slot being polled [#1048] - Corrected an issue with entry icons while merging [#1008] - Corrected desktop and tray icons in Snap package [#1030] - Fixed screen lock and Google fallback settings [#1029]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as in #1096 but with target set to
release/2.2.2.Description
The boolean parameter
okhas always been set totrue, regardless of possible errors.Motivation and context
I found this bug while skimming through the source code.
How has this been tested?
not tested. testing would require to pass a faulty crypto block to
SymmetricCipherGcrypt::process.Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]