Corrected issues with desktop and tray icons in snap build#1030
Merged
droidmonkey merged 1 commit intorelease/2.2.2from Oct 3, 2017
Merged
Corrected issues with desktop and tray icons in snap build#1030droidmonkey merged 1 commit intorelease/2.2.2from
droidmonkey merged 1 commit intorelease/2.2.2from
Conversation
TheZ3ro
approved these changes
Oct 3, 2017
phoerious
added a commit
that referenced
this pull request
Oct 21, 2017
- Fixed entries with empty URLs being reported to KeePassHTTP clients [#1031] - Fixed YubiKey detection and enabled CLI tool for AppImage binary [#1100] - Added AppStream description [#1082] - Improved TOTP compatibility and added new Base32 implementation [#1069] - Fixed error handling when processing invalid cipher stream [#1099] - Fixed double warning display when opening a database [#1037] - Fixed unlocking databases with --pw-stdin [#1087] - Added ability to override QT_PLUGIN_PATH environment variable for AppImages [#1079] - Fixed transform seed not being regenerated when saving the database [#1068] - Fixed only one YubiKey slot being polled [#1048] - Corrected an issue with entry icons while merging [#1008] - Corrected desktop and tray icons in Snap package [#1030] - Fixed screen lock and Google fallback settings [#1029]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I took a deep dive into how snaps work and came out well educated. This fix corrects desktop and tray icons issue. For whatever reason, the snap build refused to load the keepassxc application icon from the files and insisted it was loaded in the icon cache. I had to add a define to force loading from files for these icons. This define may prove useful in the future if we need to make other code-level exceptions for snaps.
I also cleaned up the snapcraft.yaml file and added some new tricks recently added in snapd.
Motivation and context
I like things to look pretty.
How has this been tested?
Manually
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]