Issue 1077: allow overriding / extending QT_PLUGIN_PATH#1079
Merged
phoerious merged 5 commits intorelease/2.2.2from Oct 19, 2017
Merged
Issue 1077: allow overriding / extending QT_PLUGIN_PATH#1079phoerious merged 5 commits intorelease/2.2.2from
phoerious merged 5 commits intorelease/2.2.2from
Conversation
edec7dc to
acb6300
Compare
TheZ3ro
approved these changes
Oct 16, 2017
droidmonkey
requested changes
Oct 16, 2017
Member
droidmonkey
left a comment
There was a problem hiding this comment.
you forgot to change out where it uses the snap build define in filepath.cpp
Member
Author
|
@droidmonkey Good catch. Please check again. |
6f26a49 to
a8e63e2
Compare
phoerious
added a commit
that referenced
this pull request
Oct 21, 2017
- Fixed entries with empty URLs being reported to KeePassHTTP clients [#1031] - Fixed YubiKey detection and enabled CLI tool for AppImage binary [#1100] - Added AppStream description [#1082] - Improved TOTP compatibility and added new Base32 implementation [#1069] - Fixed error handling when processing invalid cipher stream [#1099] - Fixed double warning display when opening a database [#1037] - Fixed unlocking databases with --pw-stdin [#1087] - Added ability to override QT_PLUGIN_PATH environment variable for AppImages [#1079] - Fixed transform seed not being regenerated when saving the database [#1068] - Fixed only one YubiKey slot being polled [#1048] - Corrected an issue with entry icons while merging [#1008] - Corrected desktop and tray icons in Snap package [#1030] - Fixed screen lock and Google fallback settings [#1029]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch resolves #1077 by allowing the user to extend the QT_PLUGIN_PATH environment variable with the contents of KPXC_QT_PLUGIN_PATH when starting the AppImage.
I also added the distribution type (AppImage / Snap) to the Debug Info screen on the About dialog.
Motivation and context
Users may want to load custom Qt plugins (which may crash KeePassXC, but may as well work).
Types of changes
Checklist: