🐛 Fix result propagation in SymmetricCipherGcrypt::process#1096
Closed
petermax2 wants to merge 88 commits intokeepassxreboot:release/2.2.2from
petermax2:crypto_fix
Closed
🐛 Fix result propagation in SymmetricCipherGcrypt::process#1096petermax2 wants to merge 88 commits intokeepassxreboot:release/2.2.2from petermax2:crypto_fix
petermax2 wants to merge 88 commits intokeepassxreboot:release/2.2.2from
petermax2:crypto_fix
Conversation
Bring unlock database dialog to the front
Fix release building and require CMake 3.1+
Added proper plural processing in CSV importer (localization)
…embedded one in case it is not found
detect system zxcvbn library
Fix apply button on settings window
Update issue template to ask for debug info from new About dialog
📝 Remove reference to Google Groups from CONTRIBUTING.md
Split auto-type title and URL matching into separate options (fixes #638)
* the url for script functions.sh was changed, see [functions.sh](https://github.com/AppImage/AppImages/raw/master/functions.sh) * for information, **bug** on appImage: functions.sh don't build on debian, see [pull request](AppImageCommunity/pkg2appimage#252) then release-tool don't work. the PR was accepted, and it is **important** for debian platforms
AppImage fixes for 32 bit architectures
and format better.
Fix url to build environment instructions
…for-placeholders Implement recursive resolving for placeholders
The boolean 'ok' has always been set to true, regardless of possible errors.
phoerious
approved these changes
Oct 21, 2017
Member
|
Could you change the target to release/2.2.2 please? Thanks! |
Remove emoji in commit messages from style guide
…-inline-message-widget Add auto hide functionality to inline message widget (#1006)
louib
approved these changes
Oct 21, 2017
Contributor
Author
|
Does this work for you or should I re-open the PR and commit to release/2.2.2? |
Member
|
You could have just rebased your branch. ;-) |
Contributor
Author
|
Oops I did not think about that. Thank you for pointing it out! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The boolean parameter
okhas always been set totrue, regardless of possible errors.Motivation and context
I found this bug while skimming through the source code.
How has this been tested?
not tested. testing would require to pass a faulty crypto block to
SymmetricCipherGcrypt::process.Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]