Skip to content

Fix release building and require CMake 3.1+#664

Merged
droidmonkey merged 2 commits intodevelopfrom
feature/fix-release-building
Jun 26, 2017
Merged

Fix release building and require CMake 3.1+#664
droidmonkey merged 2 commits intodevelopfrom
feature/fix-release-building

Conversation

@phoerious
Copy link
Copy Markdown
Member

This PR

  • removes any checks from the build command of the release tool except the check for a clean working tree
  • makes CMake 3.1 the minimum required version
  • updates the Docker file to use a not-so-ancient CMake version and Qt 5.9

Types of changes

  • ✅ Bug fix (non-breaking change which fixes an issue)

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]

@phoerious phoerious added this to the v2.2.1 milestone Jun 26, 2017
@phoerious phoerious requested a review from droidmonkey June 26, 2017 00:29
@droidmonkey droidmonkey merged commit 9d1c58a into develop Jun 26, 2017
@droidmonkey droidmonkey deleted the feature/fix-release-building branch June 26, 2017 00:59
@droidmonkey
Copy link
Copy Markdown
Member

We should do another groom of the cmake files with a focus on automation. CPack is capable of kicking off signing and digests. https://cmake.org/pipermail/cmake/2011-April/044003.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants