Skip to content

Kyodev patch 2#737

Merged
phoerious merged 2 commits intokeepassxreboot:developfrom
kyodev:kyodev-patch-2
Jul 3, 2017
Merged

Kyodev patch 2#737
phoerious merged 2 commits intokeepassxreboot:developfrom
kyodev:kyodev-patch-2

Conversation

@kyodev
Copy link
Copy Markdown
Contributor

@kyodev kyodev commented Jul 3, 2017 •
edited
Loading

Description

  • the url for script functions.sh was changed, see functions.sh
  • add 32bits architecture for release-tool

Motivation and context

  • for information, bug on appImage: functions.sh don't build on debian, see pull request then release-tool don't work.
    the PR was accepted, and it is important for debian platforms
  • release-tool don't work on 32bits architecture

How has this been tested?

  • before PR 252 (on AppImage), I can't build with release-tool, on Stretch or Sid
    after Pull Request, I can
  • I make a build, with success and use the image builded

Types of changes

  • add /usr/lib/i386-linux-gnu in
  • ✅ New feature (non-breaking change which adds functionality)

Checklist:

  • ✅ I have read the CONTRIBUTING document.
  • ✅ My code follows the code style of this project.
  • ? All new and existing tests passed. I dont think that the tests concern release-tool
  • ✅ I have worked with release-tool and I use on KeePassXC 2.2.0 on debian 32bits & 64 bits

Kyodev added 2 commits July 3, 2017 01:33
fix url for functions.sh
55d863a 
* the url for script functions.sh was changed, see [functions.sh](https://github.com/AppImage/AppImages/raw/master/functions.sh)

* for information, **bug** on appImage: functions.sh don't build on debian, see [pull request](AppImageCommunity/pkg2appimage#252) then release-tool don't work.   
  the PR was accepted, and it is **important** for debian platforms
add 32bits architecture
0d8a3fb
@droidmonkey droidmonkey requested a review from phoerious July 3, 2017 03:22
@phoerious phoerious merged commit 7580c38 into keepassxreboot:develop Jul 3, 2017
@phoerious
Copy link
Copy Markdown
Member

phoerious commented Jul 3, 2017

Thanks for the patch!

@kyodev kyodev mentioned this pull request Jul 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phoerious phoerious phoerious approved these changes

Assignees

No one assigned

Labels

distribution platform: Linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kyodev @phoerious @droidmonkey