Split auto-type title and URL matching into separate options (fixes #638)#704
Merged
phoerious merged 1 commit intokeepassxreboot:developfrom Jun 29, 2017
Merged
Conversation
TheZ3ro
approved these changes
Jun 28, 2017
Member
|
Could you rebase this please to the current develop HEAD? |
149328b to
ceeeee3
Compare
Contributor
Author
|
Done. |
Member
|
Thanks! |
Contributor
|
Why we don't merge this in 2.2.1 ? |
Member
|
We could, but we already merged quite a few new features into 2.2.1 for a bugfix release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user requested KeePassXC to have separate options to match the title and URL of an entry like in KeePass.
Description
Created second checkbox for URL matching, new configuration option with default on, changed auto-type window matching logic to test them separately.
Release note: the new checkbox is checked by default like the old one was so if one has title matching disabled URL matching will become enabled anyway until unchecked.
Motivation and context
Issue #638.
How has this been tested?
Two entries where one has matching title only and one which has matching URL only.
Screenshots (if appropriate):
Types of changes
Checklist: