Official KMCP Support #683

EItanya · 2025-08-04T19:40:31Z

This PR bring official KMCP support to KAGENT 🎉

Changes Agent API to allow pointing to Service, MCPServer or new RemoteMCPServer
Removed ToolServer in favor of new RemoteMCPServer

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

Copilot

Pull Request Overview

This PR brings official KMCP (Kubernetes Model Control Protocol) support to KAGENT by refactoring the Agent API to support multiple server types including Service, MCPServer, and the new RemoteMCPServer. The major change is replacing the legacy ToolServer with RemoteMCPServer while adding support for MCP service discovery.

Introduces new RemoteMCPServer CRD (v1alpha2) to replace legacy ToolServer
Updates Agent API to reference tools using typed object references instead of string references
Adds support for MCP service auto-discovery through Kubernetes Services

Reviewed Changes

Copilot reviewed 91 out of 94 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
ui/src/types/index.ts	Updates TypeScript interfaces for tool references from string refs to typed references
ui/src/lib/toolUtils.ts	Refactors tool utility functions to use new typed reference structure
ui/src/components/*/tsx	Updates UI components to handle new tool reference format
ui/src/app/actions/agents.ts	Modifies agent actions to work with typed tool references
helm/*/yaml	Migrates Helm charts from v1alpha1 to v1alpha2 API versions
go/pkg/client/api/types.go	Updates API types to use v1alpha2 versions
go/internal/*/go	Refactors Go code to support new KMCP architecture
go/controller/*/go	Implements new controllers for RemoteMCPServer and MCP service discovery

ui/src/components/sidebars/AgentDetailsSidebar.tsx

Copilot · 2025-08-04T19:42:14Z

go/controller/translator/adk_api_translator.go

+				break
+			}
+		}
+		return nil, fmt.Errorf("no port found for service %s with protocol %s", svc.Name, protocol)


This error is returned even when a port is found (port != 0). The return statement should be moved outside the for loop or the logic should be restructured to only return this error when no matching port is found.

Suggested change

return nil, fmt.Errorf("no port found for service %s with protocol %s", svc.Name, protocol)

if port == 0 {

return nil, fmt.Errorf("no port found for service %s with protocol %s", svc.Name, protocol)

}

Copilot · 2025-08-04T19:42:14Z

go/controller/translator/adk_api_translator.go

-			if state.isVisited(toolRef) {
-				return nil, nil, fmt.Errorf("cycle detected in agent tool chain: %s -> %s", agentRef, toolRef)
+			if state.isVisited(agentRef.String()) {
+				return nil, nil, fmt.Errorf("cycle detected in agent tool chain: %s -> %s", agentRef, agentRef.String())


The error message shows the same reference twice (agentRef and agentRef.String()). It should show the current agent and the tool reference that creates the cycle.

Suggested change

return nil, nil, fmt.Errorf("cycle detected in agent tool chain: %s -> %s", agentRef, agentRef.String())

currentAgentRef := types.NamespacedName{Name: agent.Name, Namespace: agent.Namespace}

return nil, nil, fmt.Errorf("cycle detected in agent tool chain: %s -> %s", currentAgentRef, agentRef)

Copilot · 2025-08-04T19:42:14Z

go/controller/translator/adk_api_translator.go


 			if state.depth > MAX_DEPTH {
-				return nil, nil, fmt.Errorf("recursion limit reached in agent tool chain: %s -> %s", agentRef, toolRef)
+				return nil, nil, fmt.Errorf("recursion limit reached in agent tool chain: %s -> %s", agentRef, agentRef.String())


Same issue as above - the error message shows the same reference twice instead of showing the chain that caused the recursion limit.

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>