feat: implement backend for models ui #690

UriZafrir · 2025-08-05T23:17:05Z

this is to solve this error when trying to go to /api/models

2025-08-05T21:57:36Z    DEBUG   http    Request started {"method": "GET", "path": "/api/models", "remote_addr": "10.244.0.7:51442", "user_id": "admin@kagent.dev"}
2025-08-05T21:57:36Z    INFO    http.model-handler      Listing supported models        {"method": "GET", "path": "/api/models", "remote_addr": "10.244.0.7:51442", "user_id": "admin@kagent.dev", "operation": "list-supported-models"}
2025-08-05T21:57:36Z    INFO    http    Not implemented {"method": "GET", "path": "/api/models", "remote_addr": "10.244.0.7:51442", "user_id": "admin@kagent.dev"}
2025-08-05T21:57:36Z    INFO    http    Request completed       {"method": "GET", "path": "/api/models", "remote_addr": "10.244.0.7:51442", "user_id": "admin@kagent.dev", "status": 501, "duration": "69.831µs"}

EItanya

Left comment on the go code, will leave the rest to @peterj

EItanya · 2025-08-06T19:01:37Z

go/internal/httpserver/handlers/models.go

+// ModelInfo represents information about a model
+type ModelInfo struct {
+	Name           string `json:"name"`
+	FunctionCalling bool   `json:"function_calling"`
+}
+
+// ProviderModels represents a map of provider names to their supported models
+type ProviderModels map[string][]ModelInfo
+


Can you use the types defined in pkg/client/model.go? That way the client code can stay up to date

EItanya · 2025-08-06T19:02:53Z

go/internal/httpserver/handlers/models.go

-	// TODO: Implement this
+	// Create a map of provider names to their supported models
+	// The keys need to match what the UI expects (camelCase for API keys)
+	supportedModels := ProviderModels{


This is a great start, but I do think we need a better "authoritative" list of these models. We should still merge something like this, but just want to put that out there.

updated as requested.

Signed-off-by: urizaf-work <uri.zafrir@kaltura.com> Signed-off-by: urizaf <urizaf@gmail.com>

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

* update READMEs based on new architecture Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * PR comments Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * Update ui/README.md --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

* - fixes adk performance tuning - dependency versions update Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * fix VERSION in case forked repository without tags Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * revert uv version Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * updated golden e2e Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * fix helm unit tests Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com>

* feat: make streaming buffer size configurable Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * switch to resource quantities for buffer size Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com>

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com>

* EP-685-kmcp Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * Update design/EP-685-kmcp.md Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Lin Sun <lin.sun@solo.io> Signed-off-by: urizaf <urizaf@gmail.com>

Signed-off-by: urizaf <urizaf@gmail.com>

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

…agent-dev#692) Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

…d resources (kagent-dev#703) * fix(controller): watch secrets from agents controller Ref: https://book.kubebuilder.io/reference/watching-resources/secondary-resources-not-owned Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch memory from agents controller Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch toolservers from agents controller Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch modelconfig from agent controller Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch secrets from model config controller Agent watches ModelConfig -> ModelConfig watches Secret Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * refactor(controller): consistent error logging Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * refactor(controller): remove `reconcileAgents` This isn't needed any more - we only ever reconcile a single agent at a time now. Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): ensure api key secret exists for model config Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * refactor(controller): explicitly set error to nil for memory status Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> --------- Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

peterj · 2025-08-07T13:20:04Z

Could we use the actual Gemini icon? (there's one here: https://commons.wikimedia.org/wiki/File:Google-gemini-icon.svg)

Signed-off-by: urizaf <urizaf@gmail.com>

…Zafrir/kagent into feat-implement-backend-for-models-ui

UriZafrir · 2025-08-07T15:23:05Z

done

…nya/kmcp * 'eitanya/kmcp' of github.com:kagent-dev/kagent: make audit bump go and some cve (#712) make shebang more portable (#715) feat: implement backend for models ui (#690)

UriZafrir requested review from EItanya and ilackarms as code owners August 5, 2025 23:17

UriZafrir force-pushed the feat-implement-backend-for-models-ui branch from 0fed037 to 4e9f345 Compare August 5, 2025 23:18

UriZafrir requested a review from peterj as a code owner August 6, 2025 00:07

UriZafrir force-pushed the feat-implement-backend-for-models-ui branch from f7a092a to 07a8ff3 Compare August 6, 2025 00:26

EItanya requested changes Aug 6, 2025

View reviewed changes

urizaf-work and others added 12 commits August 7, 2025 16:05

feat: implement backend for models ui

f6858a3

Signed-off-by: urizaf-work <uri.zafrir@kaltura.com> Signed-off-by: urizaf <urizaf@gmail.com>

add missing providers so they all appear in ui

1a0ebfa

Signed-off-by: urizaf-work <uri.zafrir@kaltura.com> Signed-off-by: urizaf <urizaf@gmail.com>

fix(ui): correctly display args for tool calls in chat (kagent-dev#688)

27e5711

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

eitanya/fix-python-release (kagent-dev#698)

8e27483

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com>

use the types defined in pkg/client/model.go

4a37596

Signed-off-by: urizaf <urizaf@gmail.com>

fix(ui): correct link to switch agent from within chat (kagent-dev#667)

db4809d

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

fix(ui): display description for agent tools when editing an agent (k…

a67822e

…agent-dev#692) Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com>

UriZafrir force-pushed the feat-implement-backend-for-models-ui branch from 51ba9ed to 432369a Compare August 7, 2025 13:05

github-actions bot added the enhancement-proposal Indicates that this PR is for an enhancement proposal label Aug 7, 2025

Merge branch 'main' into feat-implement-backend-for-models-ui

28865ba

UriZafrir added 2 commits August 7, 2025 18:21

change to correct Gemini icon

ee22f70

Signed-off-by: urizaf <urizaf@gmail.com>

Merge branch 'feat-implement-backend-for-models-ui' of github.com:Uri…

b5a6c6e

…Zafrir/kagent into feat-implement-backend-for-models-ui

Merge branch 'main' into feat-implement-backend-for-models-ui

b6db312

EItanya approved these changes Aug 7, 2025

View reviewed changes

peterj approved these changes Aug 8, 2025

View reviewed changes

Merge branch 'main' into feat-implement-backend-for-models-ui

76a1133

peterj merged commit 1797ed9 into kagent-dev:main Aug 8, 2025
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: implement backend for models ui #690

feat: implement backend for models ui #690

Uh oh!

UriZafrir commented Aug 5, 2025 •

edited

Loading

Uh oh!

EItanya left a comment

Uh oh!

EItanya Aug 6, 2025

Uh oh!

EItanya Aug 6, 2025

Uh oh!

UriZafrir Aug 7, 2025

Uh oh!

peterj commented Aug 7, 2025

Uh oh!

UriZafrir commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: implement backend for models ui #690

feat: implement backend for models ui #690

Uh oh!

Conversation

UriZafrir commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EItanya left a comment

Choose a reason for hiding this comment

Uh oh!

EItanya Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

EItanya Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

UriZafrir Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

peterj commented Aug 7, 2025

Uh oh!

UriZafrir commented Aug 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

UriZafrir commented Aug 5, 2025 •

edited

Loading