[FIX ] - fixes adk performance tuning #689

dimetron · 2025-08-05T23:11:02Z

dependency versions update
fixes adk performance tuning

- dependency versions update Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Copilot

Pull Request Overview

This pull request focuses on performance optimization for the ADK (Application Development Kit) component through dependency updates, resource allocation improvements, and containerization enhancements.

Updates multiple tool versions and dependencies (Go, Python packages, Kubernetes, Node.js, etc.)
Optimizes Python container runtime with bytecode compilation and memory management settings
Adjusts resource limits and health check intervals for better performance in Kubernetes deployments

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
python/pyproject.toml	Adds protobuf dependency for development
python/packages/kagent-adk/pyproject.toml	Introduces memory monitoring dependency group with psutil
python/Dockerfile	Optimizes Python runtime with bytecode compilation and malloc tuning
helm/tools/querydoc/templates/deployment.yaml	Adjusts health check timing for better performance
helm/kagent/values.yaml	Increases CPU limits from 500m to 2 cores
go/go.mod	Updates Go version and multiple dependencies
go/controller/translator/adk_api_translator.go	Enhances deployment strategy and adjusts resource allocations
Makefile	Updates tool versions for UV, Bun, Node.js, and Kind

Comments suppressed due to low confidence (7)

python/pyproject.toml:6

The protobuf version 6.31.1 does not exist. The latest protobuf version is in the 4.x series (e.g., 4.25.x). Consider using "protobuf>=4.25.0" instead.

  "protobuf>=6.31.1",

python/packages/kagent-adk/pyproject.toml:40

The psutil version 6.1.0 does not exist. The latest psutil version is in the 5.x series (e.g., 5.9.x). Consider using "psutil>=5.9.0" instead.

  "psutil>=6.1.0",  # For memory monitoring

go/go.mod:3

Go version 1.24.5 does not exist. The latest Go version is 1.23.x series. Consider using a valid Go version like "go 1.23" or "go 1.22".

go 1.24.5

go/go.mod:29

The sigs.k8s.io/yaml version 1.6.0 does not exist. The latest version is v1.4.0. Consider using "sigs.k8s.io/yaml v1.4.0" instead.

	sigs.k8s.io/yaml v1.6.0

go/go.mod:18

The github.com/spf13/pflag version 1.0.7 does not exist. The latest version is v1.0.5. Consider using "github.com/spf13/pflag v1.0.5" instead.

	github.com/spf13/pflag v1.0.7

go/go.mod:121

The go.yaml.in/yaml/v2 version 2.4.2 does not exist. The correct module name is "gopkg.in/yaml.v2" and the latest version is v2.4.0. Consider using "gopkg.in/yaml.v2 v2.4.0" instead.

	go.yaml.in/yaml/v2 v2.4.2 // indirect

go/controller/translator/adk_api_translator.go

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

EItanya

Just 2 small nits, PR looks good overall

EItanya · 2025-08-06T11:56:48Z

python/Dockerfile

-RUN uv version ${VERSION%%-*} --package kagent \
-    && uv build --package kagent \
+    && uv sync --locked --refresh                       \
+    && uv build --package kagent-adk                    \


Why did you remove uv version. That allows for the proper version to be reported by the Python code.

EItanya · 2025-08-06T11:57:59Z

helm/tools/querydoc/templates/deployment.yaml

              port: http
-            periodSeconds: 1
-            initialDelaySeconds: 1
+            periodSeconds: 15


15 seems like a for a startup probe, the point of this is just to run at startup, I understand for a readiness probe that runs for the whole lifetime.

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

EItanya

Awesome work tracking down these issues :)

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

…ture/adk-perf-fixes

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

…nya/kmcp * 'eitanya/kmcp' of github.com:kagent-dev/kagent: [FIX ] - fixes adk performance tuning (#689) update READMEs based on new architecture (#684) fix(ui): correctly display args for tool calls in chat (#688)

* - fixes adk performance tuning - dependency versions update Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * fix VERSION in case forked repository without tags Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * revert uv version Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * updated golden e2e Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * fix helm unit tests Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com>

* feat: implement backend for models ui Signed-off-by: urizaf-work <uri.zafrir@kaltura.com> Signed-off-by: urizaf <urizaf@gmail.com> * add missing providers so they all appear in ui Signed-off-by: urizaf-work <uri.zafrir@kaltura.com> Signed-off-by: urizaf <urizaf@gmail.com> * fix(ui): correctly display args for tool calls in chat (#688) Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com> * update READMEs based on new architecture (#684) * update READMEs based on new architecture Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * PR comments Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * Update ui/README.md --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com> * [FIX ] - fixes adk performance tuning (#689) * - fixes adk performance tuning - dependency versions update Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * fix VERSION in case forked repository without tags Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * revert uv version Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * updated golden e2e Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> * fix helm unit tests Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com> * feat: make streaming buffer size configurable (#696) * feat: make streaming buffer size configurable Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * switch to resource quantities for buffer size Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com> * eitanya/fix-python-release (#698) Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: urizaf <urizaf@gmail.com> * EP-685-kmcp (#686) * EP-685-kmcp Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> * Update design/EP-685-kmcp.md Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Lin Sun <lin.sun@solo.io> Signed-off-by: urizaf <urizaf@gmail.com> * use the types defined in pkg/client/model.go Signed-off-by: urizaf <urizaf@gmail.com> * fix(ui): correct link to switch agent from within chat (#667) Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com> * fix(ui): display description for agent tools when editing an agent (#692) Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com> * fix(controller): watch secondary resources instead of updating unowned resources (#703) * fix(controller): watch secrets from agents controller Ref: https://book.kubebuilder.io/reference/watching-resources/secondary-resources-not-owned Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch memory from agents controller Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch toolservers from agents controller Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch modelconfig from agent controller Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): watch secrets from model config controller Agent watches ModelConfig -> ModelConfig watches Secret Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * refactor(controller): consistent error logging Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * refactor(controller): remove `reconcileAgents` This isn't needed any more - we only ever reconcile a single agent at a time now. Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * fix(controller): ensure api key secret exists for model config Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> * refactor(controller): explicitly set error to nil for memory status Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> --------- Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: urizaf <urizaf@gmail.com> * change to correct Gemini icon Signed-off-by: urizaf <urizaf@gmail.com> --------- Signed-off-by: urizaf-work <uri.zafrir@kaltura.com> Signed-off-by: urizaf <urizaf@gmail.com> Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> Co-authored-by: urizaf-work <uri.zafrir@kaltura.com> Co-authored-by: Brian Fox <878612+onematchfox@users.noreply.github.com> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Co-authored-by: Dmytro Rashko <dmitriy.rashko@amdocs.com> Co-authored-by: Lin Sun <lin.sun@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

- fixes adk performance tuning

6aba84a

- dependency versions update Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Copilot AI review requested due to automatic review settings August 5, 2025 23:11

dimetron requested review from EItanya, ilackarms and peterj as code owners August 5, 2025 23:11

Copilot AI reviewed Aug 5, 2025

View reviewed changes

go/controller/translator/adk_api_translator.go Show resolved Hide resolved

fix VERSION in case forked repository without tags

93b64b5

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

EItanya reviewed Aug 6, 2025

View reviewed changes

dimetron and others added 2 commits August 6, 2025 14:06

revert uv version

c06d223

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Merge branch 'main' into feature/adk-perf-fixes

49bff1a

EItanya previously approved these changes Aug 6, 2025

View reviewed changes

dimetron added 2 commits August 6, 2025 14:18

updated golden e2e

203e40f

Signed-off-by: Dmytro Rashko <dmitriy.rashko@amdocs.com>

Merge remote-tracking branch 'origin/feature/adk-perf-fixes' into fea…

2fa6909

…ture/adk-perf-fixes

dimetron dismissed EItanya’s stale review via 2fa6909 August 6, 2025 12:18

fix helm unit tests

b2efefa

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>

EItanya approved these changes Aug 6, 2025

View reviewed changes

EItanya merged commit 4e010d4 into kagent-dev:main Aug 6, 2025
11 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FIX ] - fixes adk performance tuning #689

[FIX ] - fixes adk performance tuning #689

Uh oh!

dimetron commented Aug 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

EItanya left a comment

Uh oh!

EItanya Aug 6, 2025

Uh oh!

EItanya Aug 6, 2025

Uh oh!

EItanya left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[FIX ] - fixes adk performance tuning #689

[FIX ] - fixes adk performance tuning #689

Uh oh!

Conversation

dimetron commented Aug 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

EItanya left a comment

Choose a reason for hiding this comment

Uh oh!

EItanya Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

EItanya Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

EItanya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants