Skip to content

[4.2] Download Key Filters#39376

Merged
roland-d merged 4 commits intojoomla:4.2-devfrom
brianteeman:2invalidkey
Dec 17, 2022
Merged

[4.2] Download Key Filters#39376
roland-d merged 4 commits intojoomla:4.2-devfrom
brianteeman:2invalidkey

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Dec 7, 2022

The text says missing but the filter says invalid. They do not mean the same.

The text says download key but the filter says valid but it doesn't validate the key it just says if the field has content or not

Strings now comply with style guide

Testing Instructions

Install at least one extension that requires a download key.
Test with a valid key
Test with an invalid key
Test without a key

Before

image

After

image

(I'm pretty sure there was a dummy extension needing a key that was created for testing and linked to somewhere here but I cant fint it right now)

@brianteeman
[4.2] Download Key Filters
088a320 
The text says missing but the filter says invalid. They do not mean the same.

The text says download key but the filter says valid but it doesn't validate the key it just says if the field has content or not
@brianteeman
styleguide
9b297b7
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Dec 7, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Dec 7, 2022

please could someone restart drone

@richard67
Copy link
Copy Markdown
Member

richard67 commented Dec 11, 2022

(I'm pretty sure there was a dummy extension needing a key that was created for testing and linked to somewhere here but I cant fint it right now)

@brianteeman Did you mean this one? http://updates.myoldsite.com/file_null-1.0.zip I found it e.g. in PR #26769 .

@richard67
Copy link
Copy Markdown
Member

richard67 commented Dec 11, 2022

I have tested this item ✅ successfully on f6dd94a

Tested with this dummy extension: http://updates.myoldsite.com/file_null-1.0.zip

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39376.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Dec 11, 2022

(I'm pretty sure there was a dummy extension needing a key that was created for testing and linked to somewhere here but I cant fint it right now)

@brianteeman Did you mean this one? http://updates.myoldsite.com/file_null-1.0.zip I found it e.g. in PR #26769 .

yes that is the one

@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Dec 11, 2022

I have tested this item ✅ successfully on f6dd94a

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39376.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Dec 11, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39376.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 11, 2022
@roland-d roland-d merged commit 8116cc7 into joomla:4.2-dev Dec 17, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 17, 2022
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented Dec 17, 2022

Thank you

@roland-d roland-d added this to the Joomla! 4.2.7 milestone Dec 17, 2022
@brianteeman brianteeman deleted the 2invalidkey branch December 17, 2022 23:16
@jgerman-bot jgerman-bot mentioned this pull request Dec 18, 2022
Closed
@joomlapl-bot joomlapl-bot mentioned this pull request Dec 18, 2022
Closed
Kostelano added a commit to JPathRu/localisation that referenced this pull request Feb 1, 2023
@Kostelano
Новое в Joomla 4.2.7 Stable
e30c6bb 
* Joomla 4.2.6
joomla/joomla-cms#39143 - (только для en-GB)
joomla/joomla-cms#39317 - (исправлено ранее)

* Joomla 4.2.7
joomla/joomla-cms#39376 +
joomla/joomla-cms#39336 - (только для en-GB)
joomla/joomla-cms#39629 - (только для en-GB)
joomla/joomla-cms#37574 +
joomla/joomla-cms#38781 - (только для en-GB)
joomla/joomla-cms#39677 - (исправлено ранее)
joomla/joomla-cms#39682 - (только для en-GB)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

Joomla! 4.2.7

Development

Successfully merging this pull request may close these issues.

5 participants

@brianteeman @richard67 @ChristineWk @roland-d @joomla-cms-bot