Skip to content

[4.2] Grammar child/children#39143

Merged
laoneo merged 1 commit intojoomla:4.2-devfrom
brianteeman:children
Nov 9, 2022
Merged

[4.2] Grammar child/children#39143
laoneo merged 1 commit intojoomla:4.2-devfrom
brianteeman:children

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Nov 3, 2022

The error message when you try to uninstall a template that still has child templates says "children". It is better to say "child" and that is the word used everywhere else.

image

Testing Instructions

code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

The error message when you try to uninstall a template that still has child templates says "children". It is better to say "child" and that is the word used everywhere else.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Nov 3, 2022
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Nov 3, 2022

I have tested this item ✅ successfully on 457ebed

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39143.

@chmst
Copy link
Copy Markdown
Contributor

chmst commented Nov 3, 2022

I have tested this item ✅ successfully on 457ebed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39143.

@chmst chmst removed Language Change This is for Translators PR-4.2-dev labels Nov 3, 2022
@chmst
Copy link
Copy Markdown
Contributor

chmst commented Nov 3, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39143.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 3, 2022
@Quy Quy added the PR-4.2-dev label Nov 3, 2022
@richard67 richard67 added the Language Change This is for Translators label Nov 3, 2022
@laoneo laoneo merged commit 1810db6 into joomla:4.2-dev Nov 9, 2022
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Nov 9, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 9, 2022
@laoneo laoneo added this to the Joomla! 4.2.6 milestone Nov 9, 2022
@brianteeman
Copy link
Copy Markdown
Contributor Author

thanks

@brianteeman brianteeman deleted the children branch November 9, 2022 14:28
Kostelano added a commit to JPathRu/localisation that referenced this pull request Feb 1, 2023
* Joomla 4.2.6
joomla/joomla-cms#39143 - (только для en-GB)
joomla/joomla-cms#39317 - (исправлено ранее)

* Joomla 4.2.7
joomla/joomla-cms#39376 +
joomla/joomla-cms#39336 - (только для en-GB)
joomla/joomla-cms#39629 - (только для en-GB)
joomla/joomla-cms#37574 +
joomla/joomla-cms#38781 - (только для en-GB)
joomla/joomla-cms#39677 - (исправлено ранее)
joomla/joomla-cms#39682 - (только для en-GB)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants