[4.2] Fix sampledata processed and message#37574
Merged
roland-d merged 5 commits intojoomla:4.2-devfrom Jan 19, 2023
Merged
Conversation
wilsonge
approved these changes
Apr 20, 2022
07f3ab8 to
831cc13
Compare
Contributor
|
I have tested this item ✅ successfully on 635d5e3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37574. |
Contributor
|
I have tested this item ✅ successfully on bd2528e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37574. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37574. |
Contributor
|
Thank you |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Feb 1, 2023
* Joomla 4.2.6 joomla/joomla-cms#39143 - (только для en-GB) joomla/joomla-cms#39317 - (исправлено ранее) * Joomla 4.2.7 joomla/joomla-cms#39376 + joomla/joomla-cms#39336 - (только для en-GB) joomla/joomla-cms#39629 - (только для en-GB) joomla/joomla-cms#37574 + joomla/joomla-cms#38781 - (только для en-GB) joomla/joomla-cms#39677 - (исправлено ранее) joomla/joomla-cms#39682 - (только для en-GB)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix attribute for sample data set already processed
Possibility to translate the message which appears
onErrorof ajax requestTesting Instructions
onAjaxSampledataApplyStep1function of the sample data pluginActual result BEFORE applying this Pull Request
Request to confirm start is displayed and js error
No possibility to translate the message if ajax-request fails
Expected result AFTER applying this Pull Request
Alert if sample data set is already installed and no js error
Possibility to translate the message if ajax-request fails
Documentation Changes Required
none