Skip to content

[4.0] Extension update - mobile#26769

Merged
infograf768 merged 2 commits intojoomla:4.0-devfrom
brianteeman:mobile_update
Oct 23, 2019
Merged

[4.0] Extension update - mobile#26769
infograf768 merged 2 commits intojoomla:4.0-devfrom
brianteeman:mobile_update

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Oct 22, 2019

Fix the mobile view for the extension updates page by replacing a non-existant class hidden-sm and tweaked which columns to display

For testing you can use the fake extension provided by @nikosdion here http://updates.myoldsite.com/file_null-1.0.zip

Before

image
image

After

image

@brianteeman
[4.0] Extension update - mobile
d8d284f 
Fix the mobile view for the extension updates page by replacing a non-existant class `hidden-sm` and tweaked which columns to display
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Oct 22, 2019

I have tested this item ✅ successfully on d8d284f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26769.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Oct 22, 2019

@wilsonge the drone errors might be valid errors with our build script. I dont have enough access to confirm

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Oct 22, 2019

I have tested this item ✅ successfully on d8d284f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26769.

@Quy Quy removed the PR-4.0-dev label Oct 22, 2019
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Oct 22, 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26769.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 22, 2019
Quy
Quy reviewed Oct 22, 2019
View reviewed changes
administrator/components/com_installer/tmpl/update/default.php
</div>
</th>
<td class="center">
<td class="center d-none d-md-table-cell">
Copy link
Copy Markdown
Contributor

@Quy Quy Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

center can be removed. Same in the next cell.

@dgrammatiko
Copy link
Copy Markdown
Contributor

dgrammatiko commented Oct 22, 2019

@brianteeman @wilsonge not the project build tools but the version of node-sass:


Building: /usr/local/bin/node /********/src/node_modules/node-gyp/bin/node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
--
24 | gyp info it worked if it ends with ok

.
.
.

42 | gyp verb `which` failed Error: not found: python2

In plain text python is missing

@infograf768 infograf768 merged commit 2a2e177 into joomla:4.0-dev Oct 23, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 23, 2019
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Oct 23, 2019

Tks.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Oct 23, 2019

thanks

@brianteeman brianteeman deleted the mobile_update branch October 23, 2019 09:48
@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 23, 2019
@richard67 richard67 mentioned this pull request Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@brianteeman @alikon @Quy @dgrammatiko @infograf768 @zero-24 @joomla-cms-bot