Better detection for the cloudpickle wrapper#726
Merged
ogrisel merged 3 commits intojoblib:masterfrom Jul 26, 2018
Merged
Conversation
198e9af to
33ee254
Compare
GaelVaroquaux
approved these changes
Jul 25, 2018
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
Small comment.
Otherwise, looks great! And this is a very welcomed improvement.
|
|
||
| # Here, we do not need the `if __name__ == "__main__":` safeguard when | ||
| # using the default `loky` backend (even on Windows). | ||
| print(Parallel(n_jobs=2)(delayed(square)(i) for i in range(5))) |
Member
There was a problem hiding this comment.
Maybe a comment explaining why the baroque choice of arguments below.
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 95.23% 95.15% -0.08%
==========================================
Files 42 42
Lines 6103 6128 +25
==========================================
+ Hits 5812 5831 +19
- Misses 291 297 +6
Continue to review full report at Codecov.
|
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* tag '0.12.2': Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* releases: Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #643.