Fix cachedir deprecation message#720
Merged
ogrisel merged 1 commit intojoblib:masterfrom Jul 23, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 95.18% 95.13% -0.06%
==========================================
Files 40 40
Lines 5758 5758
==========================================
- Hits 5481 5478 -3
- Misses 277 280 +3
Continue to review full report at Codecov.
|
Contributor
|
Thanks for the fix. |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* tag '0.12.2': Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* releases: Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning currently says (from sklearn tests on travis):
So it gives an incorrect alternative of
location=NoneI think, while I assume it needs to be the same value as passed to cachedir? (which I did in this PR)