Skip to content

DOC: attempt to fix the build on RTD#725

Merged
GaelVaroquaux merged 1 commit intojoblib:masterfrom
GaelVaroquaux:fix_docs_build
Jul 25, 2018
Merged

DOC: attempt to fix the build on RTD#725
GaelVaroquaux merged 1 commit intojoblib:masterfrom
GaelVaroquaux:fix_docs_build

Conversation

@GaelVaroquaux
Copy link
Copy Markdown
Member

The builds on read the docs are failing because of too high memory consumption. I suspect that it is due to the example comparing compressors, and I am trying to reduce the size of the data.

This should partially fix #724

The builds on read the docs are failing because of too high memory
consumption. I suspect that it is due to the example comparing
compressors, and I am trying to reduce the size of the data.
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2018

Codecov Report

Merging #725 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   95.23%   95.09%   -0.14%     
==========================================
  Files          40       40              
  Lines        5769     5769              
==========================================
- Hits         5494     5486       -8     
- Misses        275      283       +8
Impacted Files Coverage Δ
joblib/disk.py 81.66% <0%> (-6.67%) ⬇️
joblib/_parallel_backends.py 96% <0%> (-0.8%) ⬇️
joblib/test/test_memory.py 97.49% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80c96c...43c5f0d. Read the comment docs.

@GaelVaroquaux
Copy link
Copy Markdown
Member Author

Merging to see if it does fix.

@GaelVaroquaux GaelVaroquaux merged commit 40e673d into joblib:master Jul 25, 2018
@GaelVaroquaux
Copy link
Copy Markdown
Member Author

It didn't work, RTD still died. :(.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jul 26, 2018

If you want to test different options for fixing the build on RTD and without polluting master and creating tons of PRs until it passes, you can push another branch upstream (e.g on the main joblib remote) and configure RTD to build this branch.

yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Aug 22, 2018
* tag '0.12.2':
  Release 0.12.2
  Pin numpy version for sklearn test (joblib#734)
  Loky 2.2.0 (joblib#733)
  [MRG] BatchedCalls backward compat (joblib#732)
  Better detection for the cloudpickle wrapper (joblib#726)
  DOC: attempt to fix the build on RTD (joblib#725)
  Include dask backend to fix nested parallelism and auto-scatter (joblib#722)
  FIX: re-establish argument_hash attribute for backward compat (joblib#716)
  Fix cachedir deprecation message (joblib#720)
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Aug 22, 2018
* releases:
  Release 0.12.2
  Pin numpy version for sklearn test (joblib#734)
  Loky 2.2.0 (joblib#733)
  [MRG] BatchedCalls backward compat (joblib#732)
  Better detection for the cloudpickle wrapper (joblib#726)
  DOC: attempt to fix the build on RTD (joblib#725)
  Include dask backend to fix nested parallelism and auto-scatter (joblib#722)
  FIX: re-establish argument_hash attribute for backward compat (joblib#716)
  Fix cachedir deprecation message (joblib#720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readthedocs still documents joblib 0.11

2 participants