FIX: re-establish argument_hash attribute for backward compat#716
Merged
ogrisel merged 3 commits intojoblib:masterfrom Jul 23, 2018
Merged
FIX: re-establish argument_hash attribute for backward compat#716ogrisel merged 3 commits intojoblib:masterfrom
ogrisel merged 3 commits intojoblib:masterfrom
Conversation
The argument_hash attribute is marked deprecated
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
=========================================
+ Coverage 95.07% 95.1% +0.02%
=========================================
Files 40 40
Lines 5751 5762 +11
=========================================
+ Hits 5468 5480 +12
+ Misses 283 282 -1
Continue to review full report at Codecov.
|
Contributor
|
Thanks for the fix. |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* tag '0.12.2': Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* releases: Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix #714:
argument_hashattribute for backward compatibility, since it appears that some people were using itargument_hashanymore butargs_idinstead.