registry: add porter (github:getporter/porter)#8380
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the available tools in the registry by integrating Porter, a robust CNAB bundle management solution. The primary goal is to enable users to easily install and manage Porter through the system, with specific configuration to handle its unique release asset structure and ensure proper binary detection. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for porter. The configuration looks good for Linux and macOS, but it will fail on Windows because the asset pattern doesn't account for the .exe extension and the bin option would incorrectly name the binary. I've suggested a fix that uses platform-specific backend configurations to handle Windows correctly.
Greptile SummaryAdds Porter (CNAB bundle authoring tool) to the mise registry with GitHub backend. The implementation uses an explicit Confidence Score: 4/5
Important Files Changed
Last reviewed commit: b0abc03 |
821043f to
040f6b0
Compare
| full = "github:getporter/porter" | ||
|
|
||
| [backends.options] | ||
| asset_pattern = "porter-{{ os(macos='darwin') }}-{{ arch(x64='amd64') }}{% if os() == 'windows' %}.exe{% endif %}" |
There was a problem hiding this comment.
Unfortunately not because there are other assets that will get selected instead of the porter binary in the github release.
### 🚀 Features - **(backend-plugin)** pass options to vfox backend plugins by @Attempt3035 in [#8369](#8369) ### 🐛 Bug Fixes - **(install)** prevent --locked mode from modifying or bypassing lockfile by @jdx in [#8362](#8362) - **(install)** clear aqua bin_paths cache after install to prevent stale PATH by @jdx in [#8374](#8374) - **(task)** prevent broken pipe panic and race condition in remote git task cache by @vmaleze in [#8375](#8375) ### 📦️ Dependency Updates - update docker/build-push-action digest to 10e90e3 by @renovate[bot] in [#8367](#8367) - update fedora:43 docker digest to 781b764 by @renovate[bot] in [#8368](#8368) ### 📦 Registry - add porter ([github:getporter/porter](https://github.com/getporter/porter)) by @lbergnehr in [#8380](#8380) - add entire ([aqua:entireio/cli](https://github.com/entireio/cli)) by @TyceHerrman in [#8378](#8378) - add topgrade ([aqua:topgrade-rs/topgrade](https://github.com/topgrade-rs/topgrade)) by @TyceHerrman in [#8377](#8377) ### Chore - remove pre-commit config and tool dependency by @jdx in [#8373](#8373) ### New Contributors - @Attempt3035 made their first contribution in [#8369](#8369) - @lbergnehr made their first contribution in [#8380](#8380)
Add Porter to the registry. Porter is a CNAB bundle authoring and management tool.
An explicit
asset_patternis needed because Porter releases contain multiple binaries (porter-*,exec-*,agent-*) and mise's autodetection picks the wrong asset.