Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two critical issues in the remote git task cache: potential panics due to broken pipes and race conditions leading to cache corruption. It enhances the robustness and reliability of the task fetching process by implementing safer output writing and ensuring atomic cache updates.

Highlights

• Broken Pipe Handling: Replaced println! and eprintln! with writeln! to prevent panics caused by broken pipes (EPIPE) when fetching remote git tasks.
• Race Condition Prevention: Implemented file locking and a clone-to-temp-then-rename strategy to prevent concurrent cache corruption when fetching remote git tasks.

Greptile Summary

This PR fixes two related issues in task execution: EPIPE panics and race conditions in remote git task caching. The changes prevent crashes when stdout/stderr is closed unexpectedly by replacing panicking I/O macros with error-returning alternatives, and eliminate cache corruption from concurrent access by implementing proper file locking with atomic clone-to-temp-then-rename operations.

• src/cmd.rs: Replaced println! and eprintln! with writeln! on locked stdout/stderr handles, ignoring errors to gracefully handle EPIPE conditions
• src/task/task_file_providers/remote_task_git.rs: Added LockFile to serialize concurrent cache access, implemented atomic updates via temporary directory cloning followed by rename operation

The implementation follows best practices for concurrent file operations and error handling. No issues found.

Confidence Score: 5/5

• This PR is safe to merge with no identified risks
• Both changes follow well-established patterns for handling EPIPE errors and preventing concurrent file corruption. The EPIPE fix uses the standard approach of replacing panicking macros with Result-returning alternatives. The cache protection implements proper locking with atomic rename operations, preventing race conditions while maintaining correct cleanup on all code paths.
• No files require special attention

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Start: get_local_path] --> B[Acquire Lock on destination]
    B --> C{is_cached == true?}
    C -->|Yes| D{full_path exists?}
    D -->|Yes| E[Return cached file]
    D -->|No| F[Continue to clone]
    C -->|No| F
    F --> G[Clean up tmp_destination if exists]
    G --> H[Clone repo to tmp_destination]
    H --> I{Clone successful?}
    I -->|No| J[Clean up tmp_destination]
    J --> K[Return error]
    I -->|Yes| L[Remove destination if exists]
    L --> M[Rename tmp_destination to destination]
    M --> N{Rename successful?}
    N -->|No| O[Clean up tmp_destination]
    O --> P[Return error]
    N -->|Yes| Q[Return full_path]
    E --> R[Release lock]
    K --> R
    P --> R
    Q --> R

_{Last reviewed commit: b718a6d}