Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine release of Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Greptile SummaryStandard automated release PR that bumps version from 2026.2.22 to 2026.2.23 across all package manifests and documentation.
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 10c6d1d |
There was a problem hiding this comment.
Code Review
This pull request updates the version to 2026.2.23 across various files for the new release. The changes are consistent and appear correct for a release bump. I've provided suggestions to improve the shell completion scripts by removing the hardcoded version from the generated spec file names. This will make the completions more robust, especially for users who update mise via self-update, by ensuring the completion spec is always synchronized with the installed binary.
| fi | ||
|
|
||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_2_22.spec" | ||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_2_23.spec" |
There was a problem hiding this comment.
Hardcoding the version in the spec file name can make completions brittle, especially for users who update mise using self-update. The completion script won't be updated, leading to potential issues if the spec format changes or if the old spec is used with a new binary.
A more robust approach would be to use a static file name and regenerate it only when the mise binary is updated. This can be achieved by comparing file modification times.
Consider replacing lines 26-29 with the following:
local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise.spec"
local mise_bin
mise_bin=$(command -v mise)
if [[ ! -f "$spec_file" || "$spec_file" -ot "$mise_bin" ]]; then
mise usage > "$spec_file"
fiThis ensures the completion spec is always in sync with the installed mise version.
| local cur prev words cword was_split comp_args | ||
| _comp_initialize -n : -- "$@" || return | ||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_2_22.spec" | ||
| local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise_2026_2_23.spec" |
There was a problem hiding this comment.
Hardcoding the version in the spec file name can make completions brittle, especially for users who update mise using self-update. The completion script won't be updated, leading to potential issues.
A more robust approach is to use a static file name and regenerate it when the mise binary is newer than the spec file.
Consider replacing lines 12-15 with:
local spec_file="${TMPDIR:-/tmp}/usage__usage_spec_mise.spec"
local mise_bin
mise_bin=$(command -v mise)
if [[ ! -f "$spec_file" || "$spec_file" -ot "$mise_bin" ]]; then
mise usage > "$spec_file"
fiThis ensures the completion spec is always up-to-date with the mise executable.
| end | ||
| set -l tmpdir (if set -q TMPDIR; echo $TMPDIR; else; echo /tmp; end) | ||
| set -l spec_file "$tmpdir/usage__usage_spec_mise_2026_2_22.spec" | ||
| set -l spec_file "$tmpdir/usage__usage_spec_mise_2026_2_23.spec" |
There was a problem hiding this comment.
Hardcoding the version in the spec file name can make completions brittle, especially for users who update mise using self-update. The completion script won't be updated, leading to potential issues.
A more robust approach is to use a static file name and regenerate it when the mise binary is newer than the spec file.
Consider replacing lines 11-14 with:
set -l spec_file "$tmpdir/usage__usage_spec_mise.spec"
set -l mise_bin (command -v mise)
if not test -f "$spec_file" -o (test "$spec_file" -ot "$mise_bin")
mise usage | string collect > "$spec_file"
endThis ensures the completion spec is always in sync with the mise executable.
|
|
||
| $tmpDir = if ($env:TEMP) { $env:TEMP } else { [System.IO.Path]::GetTempPath() } | ||
| $specFile = Join-Path $tmpDir "usage__usage_spec_mise_2026_2_22.kdl" | ||
| $specFile = Join-Path $tmpDir "usage__usage_spec_mise_2026_2_23.kdl" |
There was a problem hiding this comment.
Hardcoding the version in the spec file name can make completions brittle, especially for users who update mise using self-update. The completion script won't be updated, leading to potential issues.
A more robust approach is to use a static file name and regenerate it when the mise binary is newer than the spec file.
Consider replacing lines 13-17 with:
$specFile = Join-Path $tmpDir "usage__usage_spec_mise.kdl"
$miseBin = Get-Command mise | Select-Object -ExpandProperty Source
if (-not (Test-Path $specFile) -or ((Get-Item $specFile).LastWriteTime -lt (Get-Item $miseBin).LastWriteTime)) {
mise usage | Out-File -FilePath $specFile -Encoding utf8
}This ensures the completion spec is always up-to-date with the mise executable.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.22 x -- echo |
23.4 ± 1.0 | 22.2 | 30.7 | 1.00 |
mise x -- echo |
23.6 ± 0.8 | 22.4 | 29.3 | 1.01 ± 0.05 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.22 env |
22.9 ± 0.7 | 21.8 | 28.9 | 1.00 |
mise env |
23.1 ± 0.9 | 21.9 | 34.6 | 1.01 ± 0.05 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.22 hook-env |
23.4 ± 0.6 | 22.4 | 25.0 | 1.00 |
mise hook-env |
23.6 ± 0.6 | 22.6 | 25.3 | 1.01 ± 0.04 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.2.22 ls |
23.0 ± 0.8 | 21.9 | 28.8 | 1.01 ± 0.04 |
mise ls |
22.9 ± 0.6 | 21.9 | 24.5 | 1.00 |
xtasks/test/perf
| Command | mise-2026.2.22 | mise | Variance |
|---|---|---|---|
| install (cached) | 149ms | 150ms | +0% |
| ls (cached) | 84ms | 85ms | -1% |
| bin-paths (cached) | 87ms | 88ms | -1% |
| task-ls (cached) | 773ms | 776ms | +0% |
e185965 to
0573d23
Compare
🚀 Features
🐛 Bug Fixes
📦️ Dependency Updates
📦 Registry
Chore
New Contributors