Skip to content

chore: remove pre-commit config and tool dependency#8373

Merged
jdx merged 1 commit intomainfrom
chore/remove-pre-commit-config
Feb 27, 2026
Merged

chore: remove pre-commit config and tool dependency#8373
jdx merged 1 commit intomainfrom
chore/remove-pre-commit-config

Conversation

@jdx
Copy link
Owner

@jdx jdx commented Feb 27, 2026

Summary

  • Remove .pre-commit-config.yaml from the project root
  • Remove pre-commit = "latest" tool from mise.toml

Linting is handled by hk and mise tasks now, so the pre-commit tool and its config are no longer needed.

Test plan

  • Verified remaining "pre-commit" references are about mise's own git pre-commit hook feature, not the pre-commit Python tool
  • Lint checks pass

🤖 Generated with Claude Code


Note

Low Risk
Low risk: removes development-time pre-commit configuration and its mise tool entry without changing runtime code paths.

Overview
Removes the repository’s pre-commit setup by deleting .pre-commit-config.yaml and dropping the pre-commit tool from mise.toml.

This shifts lint/format enforcement fully to existing hk/mise tasks and eliminates the Python pre-commit dependency.

Written by Cursor Bugbot for commit 50c1eef. This will update automatically on new commits. Configure here.

Pre-commit is no longer used in the project; linting is handled by hk
and mise tasks. Remove .pre-commit-config.yaml and the pre-commit tool
from mise.toml.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's development environment by removing the standalone pre-commit tool and its configuration. This change is made possible because linting and other pre-commit checks are now managed directly by hk and mise tasks, eliminating the redundancy of the previous setup and simplifying the project's toolchain.

Highlights

  • Pre-commit configuration removal: The .pre-commit-config.yaml file has been entirely removed from the project root.
  • Pre-commit tool dependency removal: The pre-commit = "latest" entry has been removed from mise.toml, indicating the tool is no longer a dependency.
Changelog
  • .pre-commit-config.yaml
    • Removed the entire pre-commit configuration file.
  • mise.toml
    • Removed the pre-commit = "latest" entry from the tool dependencies.
Activity
  • The author verified that remaining "pre-commit" references in the codebase pertain to mise's internal git pre-commit hook feature, not the external Python pre-commit tool.
  • Lint checks were confirmed to pass after these changes.
  • The pull request was generated using Claude Code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jdx jdx enabled auto-merge (squash) February 27, 2026 12:54
@greptile-apps
Copy link

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Removes the Python pre-commit tool and its configuration file, migrating all linting functionality to mise tasks and the hk tool.

  • Deleted .pre-commit-config.yaml which configured hooks for trailing whitespace, file checks, shellcheck, actionlint, and cargo formatting
  • Removed pre-commit = "latest" from mise.toml tools list
  • All previous functionality is preserved through existing mise tasks in xtasks/lint/ (actionlint, cargo-fmt, hk, markdownlint, etc.)
  • CI already uses mise run lint (line 142 in .github/workflows/test.yml)

Confidence Score: 5/5

  • Safe to merge - removes unused dependency without affecting functionality
  • This is a clean removal of the Python pre-commit tool that has been superseded by mise tasks and hk. All linting functionality previously provided by the pre-commit config (shellcheck, actionlint, cargo-fmt, file checks) is already handled by existing mise tasks in xtasks/lint/. The CI workflow already uses mise run lint instead of pre-commit. No code logic is affected.
  • No files require special attention

Important Files Changed

Filename Overview
.pre-commit-config.yaml Removed Python pre-commit tool configuration; functionality now handled by mise tasks and hk
mise.toml Removed pre-commit tool dependency; linting tools (actionlint, shellcheck, hk, etc.) remain installed

Last reviewed commit: 50c1eef

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully removes the .pre-commit-config.yaml file and the pre-commit tool entry from mise.toml. These changes align with the stated objective of deprecating the pre-commit tool in favor of hk and mise tasks for linting. No specific code-level issues or improvements were identified in the changes.

@jdx jdx merged commit 97216c6 into main Feb 27, 2026
38 checks passed
@jdx jdx deleted the chore/remove-pre-commit-config branch February 27, 2026 13:09
@github-actions
Copy link

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.2.21 x -- echo 18.9 ± 0.8 17.5 25.4 1.00
mise x -- echo 19.2 ± 0.8 17.5 25.4 1.02 ± 0.06

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.2.21 env 18.6 ± 0.9 17.2 24.0 1.00
mise env 19.1 ± 3.1 17.3 83.9 1.02 ± 0.17

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.2.21 hook-env 19.1 ± 0.8 17.4 24.2 1.00
mise hook-env 19.2 ± 0.9 17.4 27.7 1.01 ± 0.07

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.2.21 ls 18.9 ± 0.7 17.5 23.5 1.00
mise ls 19.4 ± 0.8 18.0 25.1 1.03 ± 0.05

xtasks/test/perf

Command mise-2026.2.21 mise Variance
install (cached) 119ms 119ms +0%
ls (cached) 73ms 72ms +1%
bin-paths (cached) 75ms 74ms +1%
task-ls (cached) 703ms 696ms +1%

risu729 pushed a commit to risu729/mise that referenced this pull request Feb 27, 2026
## Summary
- Remove `.pre-commit-config.yaml` from the project root
- Remove `pre-commit = "latest"` tool from `mise.toml`

Linting is handled by hk and mise tasks now, so the pre-commit tool and
its config are no longer needed.

## Test plan
- [x] Verified remaining "pre-commit" references are about mise's own
git pre-commit hook feature, not the pre-commit Python tool
- [x] Lint checks pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk: removes development-time `pre-commit` configuration and its
`mise` tool entry without changing runtime code paths.
> 
> **Overview**
> Removes the repository’s `pre-commit` setup by deleting
`.pre-commit-config.yaml` and dropping the `pre-commit` tool from
`mise.toml`.
> 
> This shifts lint/format enforcement fully to existing `hk`/`mise`
tasks and eliminates the Python `pre-commit` dependency.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
50c1eef. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
mise-en-dev added a commit that referenced this pull request Feb 28, 2026
### 🚀 Features

- **(backend-plugin)** pass options to vfox backend plugins by
@Attempt3035 in [#8369](#8369)

### 🐛 Bug Fixes

- **(install)** prevent --locked mode from modifying or bypassing
lockfile by @jdx in [#8362](#8362)
- **(install)** clear aqua bin_paths cache after install to prevent
stale PATH by @jdx in [#8374](#8374)
- **(task)** prevent broken pipe panic and race condition in remote git
task cache by @vmaleze in [#8375](#8375)

### 📦️ Dependency Updates

- update docker/build-push-action digest to 10e90e3 by @renovate[bot] in
[#8367](#8367)
- update fedora:43 docker digest to 781b764 by @renovate[bot] in
[#8368](#8368)

### 📦 Registry

- add porter
([github:getporter/porter](https://github.com/getporter/porter)) by
@lbergnehr in [#8380](#8380)
- add entire ([aqua:entireio/cli](https://github.com/entireio/cli)) by
@TyceHerrman in [#8378](#8378)
- add topgrade
([aqua:topgrade-rs/topgrade](https://github.com/topgrade-rs/topgrade))
by @TyceHerrman in [#8377](#8377)

### Chore

- remove pre-commit config and tool dependency by @jdx in
[#8373](#8373)

### New Contributors

- @Attempt3035 made their first contribution in
[#8369](#8369)
- @lbergnehr made their first contribution in
[#8380](#8380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant