Closed
Conversation
These were already moved into html/ in web-platform-tests#7637, but because a bug in Chromium's exporter the original change was exported again: https://bugs.chromium.org/p/chromium/issues/detail?id=775439 The files still match exactly those in html/browsers/browsing-the-web/history-traversal/, with the exception of support/window-name-navigation.sub.html which has a (correctly) updated path, so there's no loss of coverage.
This is a first step towards having a standalone mediacapture-stream.idl. It also makes the existing test fail fast in case the getUserMedia promise is rejected.
…s. (web-platform-tests#7864) The AXRole, AXSubrole, and AXRoleDescription are already being tested by the aria-modal="false" tests. In addition, what we really need to verify for AX API when aria-modal="true" is that the background content has been removed from the accessibility tree. The role details of other elements are irrelevant in performing that verification, and their inclusion introduces noise into the results.
There seems to be a race on whether the count of datachannels is incremented before a session goes to "connected". This CL allows both 0 and 1. The test would fail ~1/4000 times on a Linux workstation. Bug: 771540 Change-Id: Ic250443c2addef995dbb26e7cd021a516dcd023b Reviewed-on: https://chromium-review.googlesource.com/721379 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#509564}
* dynamic-imports-error.html was converted to dynamic-imports-script-error.html which tests the additional cases of bad module specifiers and that the error objects are memoized appropriately. * dynamic-imports-fetch-error.sub.html was introduced to test a large variety of possible fetch errors. Also: fix errorhandling.html (a test for static imports) which was sending X-Content-Type-Options: nosniff. No sniffing should be performed for modules no matter what; the header is not relevant and might be masking a broken implementation of that requirement.
…orm-tests#7680) Missing coverage noted in w3c/IndexedDB#213 The test cases verify the `source` property of requests returned by operations made against stores, indexes, and cursors.
This makes the origin secure so that getUserMedia() doesn't fail. Updated expected file too. Bug: 771540 Change-Id: I2717e195d6fb52cd2dedf45dd5c48b05b1058823 Reviewed-on: https://chromium-review.googlesource.com/716719 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#509623}
As it follows from w3c/sensors#313 Change-Id: Ic81e118b2a3c8db6d8b30ee61ef8811b88a0f970 Reviewed-on: https://chromium-review.googlesource.com/721742 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#509707}
In some cases, relatedTarget kept its value after event dispatch has finished even though target is set to null. See test file for the cases. This change adds a check so that when target is set to null in the post-processing phase, the change is also reflected in relatedTarget. Bug: 771580 Change-Id: Idda5d00c1a793b2669be66e76439851d1f66459c Reviewed-on: https://chromium-review.googlesource.com/720897 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#509710}
* Remove SpecialPowers from css parsing tests This is Gecko-specific and doesn't even exist in wpt tests run in Gecko. * Update test_font_family_parsing.html
…m-tests#7878) Previously this always looked for changed files as required for CI. But it's also useful to test an explicit list of files locally, so check if this is passed before using the changed files.
checkLayout() method defined in resources/check-layout-th.js had a outputContainer argument that was not used. This patch removes that argument. On top of that, some tests that were trying to use that argument have been modified as it was not needed for them. Last, the copies of check-layout-th.js in WPT CSS test suites have been updated with this change and another change introduced in r377261. Change-Id: Iefb649d811e0fd09106bf3d02225539e481fa713 Reviewed-on: https://chromium-review.googlesource.com/721545 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#509752}
Fix wdspec new_session create tests Both create_alwaysMatch.py and create_firstMatch.py were failing to import support.create where the input data is shared. E ValueError: Attempted relative import in non-package Add __init__.py to support directory and remove the leading '.' from the import command in both test files.
add Jerry Smith (@jdsmith3000) as an OWNER for MS Edge
Test parsing and serialization of the following properties: - color-interpolation-filters - filter - lighting-color In particular, we test that hue-rotate(0) is accepted. w3c/fxtf-drafts#228 Some filter functions remain to be added to the tests.
Add tests for drop-shadow() with color before lengths. w3c/fxtf-drafts#231 Add tests for filter functions with no arguments supplied.
The assertion in this test did not match what the test was doing, and was probably a copy+paste leftover.
This adjusts and completes the test suite, reflecting the changes resolved in w3c/csswg-drafts#1598 (comment)
…latform-tests#7895) Those tests are not currently run because there's another function called test_invalid() overriding the previous one. Rename both as test_invalid_values() and test_invalid_extensions().
This uploads a MANIFEST.json.gz file for every commit to master, so that we can build tooling that attempts to download that file as an initial manifest that can then have a rapid update rather than a slow build.
Updating WebDriver tests session creation to have valid capabilities Several of the tests in the WebDriver suite are sending capabilities for the new session that are incomplete or incorrect. This commit corrects the capabilites payloads for the new session call to be a valid capabilities dictionary.
…dpate [css-ui-3] Cursor test udpate
…m-tests#7904) This means that manifest_upload and lint run on master. Although the lint is not going to do anything at the moment since it only runs on changed files. In the future we could make it pass --all in this case.
Checks for the issue reported in this Safari bug: https://bugs.webkit.org/show_bug.cgi?id=178995
Several of the pywebsocket handlers used in tests had the problem that they would generate a hand-crafted header and then pywebsocket would add its own header immediately afterwards, causing unnecessary errors. In most cases there was no need to generate a hand-crafted header at all, so the tests have been modified to use pywebsocket APIs to do the same thing. simple_handshake_wsh.py still generates a hand-crafted header but now suppresses pywebsocket's own header. Several tests closed the WebSocket on the client side but the handler didn't wait to receive the client-side close. These have been modified to wait for the close frame. Several tests had expectations that onclose would never be called but then called close() themselves, causing onclose to be called. In some cases this was mitigated by calling t.done() before t.unreached_func() was called, but it has been fixed by disabling the onclose handler after calling close(). This change only fixes a subset of handlers and their affected tests. It is not intended to be comprehensive, and many issues remain.
Discussed in w3c/csswg-drafts#492 Change-Id: I31172814ad0db99b2ede246f92c4611dab07c756 Reviewed-on: https://chromium-review.googlesource.com/759918 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#515117}
Copy the tests for transform streams from the whatwg/streams repository. TransformStream has now been added to the Streams Standard so it seems reasonable to move these tests to the web-platform-tests repository. A follow-on change will remove them from the whatwg/streams repository. There are no changes to the test Javascript files, except that some calls to setTimeout() have been replaced with equivalent calls to delay(). Also a duplicate test name in lipfuzz.js has been fixed. All the tests have all been reviewed in their old location. All the HTML files have been regenerated by generate-test-wrappers.js. recording-streams.js has an additional "recordingTransformStream" function which is used in some of the new tests. test-utils.js has an additional "constructorThrowsForAll" test helper.
This expands and upstreams: * chromium/frame-detached-by-navigation.html * chromium/frame-removed.html Chromium behavior seems a bit weird but for now upload the WPT to get the test visible, and we can refine the expectations later. Bug: 713732, 522791, 688116 Change-Id: I4af7fb668f9ef2e4aaff580ba129e6ae353f0e18 Reviewed-on: https://chromium-review.googlesource.com/760061 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#515134}
In particular, this catches a bug in libsoup (used by WebKitGTK), where the casing of headers depends on global state.
The exact value is not important for this test so it might as well be correct. Fixes web-platform-tests#6471.
Convert some tabs to spaces in css/css-flexbox/
This CL ensures that a child iframe does not report paint timing entries when only the parent does all of the painting. Bug: chromium:736114 Change-Id: Idcba2bb9e93eeb7168e604840df4497df4073472 Reviewed-on: https://chromium-review.googlesource.com/755857 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#515253}
Remove the old stale copy of the spec and remove js/lodash.js which is loaded in several places but not actually used for anything. Bug: 782901 Change-Id: Idfdbc9f1cf2d9edf190d649168074f4d4ec66c73 Reviewed-on: https://chromium-review.googlesource.com/759225 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515256}
The tests for element state were asserting a success after handling a user prompt. However, the way the URL end point was formatted in the test, an error response was being returned. This commit corrects that.
Tests change https://svgwg.org/svg2-draft/changes.html#extend "Made ‘foreignObject’ a graphics element."
…ests#8137) Make testharness.js output something in SVG documents
SVG2: Test foreignObject is a graphics element
This is testing web-exposed behavior. The test had a comment that Response.body is still being specced, and now it is specced. Bug: 446188, 688116 Change-Id: I4d725b9172389ad675404a817d81c321cdef13d0 Reviewed-on: https://chromium-review.googlesource.com/760496 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515336}
We are changing how we compute the grid area's size of positioned items, trying to make the logic as independent as possible of the grid container's direction. The new way of placing absolute positioned elements in their grid area is based on the previously computed area's size. This provide a mechanism to place an item in its area respecting the offsets derived from the Content Alignment CSS properties and, which is more important, ignoring the grid container's direction. Additionally, we use the already implemented alignment logic that's used for regular grid items. This patch provides almost full alignment capabilities for positioned objects, with the exception of 'stretch'. It's worth mentioning that some of the test cases using vertical-rl writing mode will fail because of the bug 779105. Bug: 603423, 777978 Change-Id: I8fb121418795244d13589d603007c70f58e1f2df Reviewed-on: https://chromium-review.googlesource.com/672423 Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#515391}
This also fixes the IgnorableCodePoint test to use inputs which have nontrivial ISO-2022-JP shift states; previously this test did not actually ensure correct behavior when non-ASCII characters representable in ISO-2022-JP and non-ASCII characters not representable in ISO-2022-JP occur in sequence. This also adds WPT coverage. Prior to this fix, encoder state was not respected, leading to incorrect interpretation of the replacements and sometimes following bytes too, depending on whether the replacement lengths were even or odd, and on whether the active state of the ISO-2022-JP G0 character set was one-byte or two-byte. An example, with results transcribed in Unicode for readability: Input: ABC~¤•★星🌟星★•¤~XYZ Old output: Bytes: ABC~&web-platform-tests#164;&web-platform-tests#8226;␛$B!z@1🌟@1!z&web-platform-tests#8226;&web-platform-tests#164;␛(B~XYZ Meaning: ABC~&web-platform-tests#164;&web-platform-tests#8226;★星Γ渦祁卦酸院惕8臆胸Γ蔚柑~XYZ New output: Bytes: ABC~&web-platform-tests#164;&web-platform-tests#8226;␛$B!z@1␛(B🌟␛$B@1!z␛(B&web-platform-tests#8226;&web-platform-tests#164;~XYZ Meaning: ABC~&web-platform-tests#164;&web-platform-tests#8226;★星🌟星★&web-platform-tests#8226;&web-platform-tests#164;~XYZ Bug: 782565 Change-Id: If2a7b76b99ce77cbec433af5384ed5c4d2e3c581 Reviewed-on: https://chromium-review.googlesource.com/758405 Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Reviewed-by: Jungshik Shin <jungshik@google.com> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515425}
… next src This fixes a bug where @font-face with font-display: optional causes unnecessary font downloads of subsequent sources when the first source fails to download by the "short time limit" (100ms). Bug: 770978 Change-Id: I24ad7c803d04b9eb310b6b916c999660a23c61b5 Reviewed-on: https://chromium-review.googlesource.com/760137 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#515453}
This implements link rel=modulepreload without submodules fetch, behind the Experimental Web Platform feature flag. LinkLoader fetches module script using Modulator::FetchSingle, so it populates the module map but does not fetch descendant modules. Unlike the preload fetches by link rel=preload, this doesn't set FetchParameters::SetLinkPreload flag, so it works like a regular script fetch. HTMLPreloadScanner fetches module scripts in a similar way to speculative preload of <script type=module>, i.e. just fetch a ScriptResource and not populate the module map. Spec PR: whatwg/html#2383 Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ynkrM70KDD4 Bug: 740886 Change-Id: I5f4420e305f4962b3fbe3f703ce95a5a43e4f7a9 Reviewed-on: https://chromium-review.googlesource.com/662697 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#515490}
Currently, EventTarget cannot be constructed or be subclassed (in JavaScript). The spec for EventTarget was updated to allow constructing and subclassing EventTarget. A new class, EventTargetImpl, is created as the user-constructable version of EventTarget. Even though the name is EventTargetImpl, it will be exposed as EventTarget to JavaScript. We are using a hacky approach by making EventTarget::Create return an instance of EventTargetImpl, which means an instance of EventTargetImpl will be returned when the EventTarget object is constructed in JavaScript. Spec: https://dom.spec.whatwg.org/#dom-eventtarget-eventtarget Design doc: https://docs.google.com/a/google.com/document/d/1TXMAkLeaNpbbETeqTyJZ57YnmqzgchyhFsANVZ2Ow3Y/edit?usp=sharing Bug: 740576 Change-Id: Ia0569ee99c4d856120c387ca6aceed5fbe1491b5 Reviewed-on: https://chromium-review.googlesource.com/754248 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#515495}
759c84c to
d3b3532
Compare
jdm
pushed a commit
that referenced
this pull request
Jan 31, 2018
…mPoint" This reverts commit dd944882a245a5117b50cb417138d92f32d931d6. Reason for revert: This causes WebKit Linux Trusty ASAN buildbot failure. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/8618 23:46:29.565 3877 ==1==ERROR: AddressSanitizer: use-after-poison on address 0x7ead60c0dbf0 at pc 0x00000dca937a bp 0x7ffd86b90c10 sp 0x7ffd86b90c08 23:46:29.565 3877 READ of size 8 at 0x7ead60c0dbf0 thread T0 (content_shell) 23:46:29.565 3877 #0 0xdca9379 in operator==<const blink::TreeScope, const blink::TreeScope> third_party/WebKit/Source/platform/heap/Member.h:128:27 23:46:29.565 3877 #1 0xdca9379 in blink::TreeScope::Retarget(blink::Element const&) const third_party/WebKit/Source/core/dom/TreeScope.cpp:393:0 23:46:29.565 3877 #2 0xdca8894 in blink::TreeScope::HitTestPointInternal(blink::Node*) const third_party/WebKit/Source/core/dom/TreeScope.cpp:267:10 23:46:29.565 3877 #3 0xdca8325 in HitTestPoint third_party/WebKit/Source/core/dom/TreeScope.cpp:254:10 23:46:29.566 3877 #4 0xdca8325 in blink::TreeScope::ElementFromPoint(double, double) const third_party/WebKit/Source/core/dom/TreeScope.cpp:245:0 23:46:29.566 3877 #5 0xc9353a7 in elementFromPoint third_party/WebKit/Source/core/dom/DocumentOrShadowRoot.h:38:23 Original change's description: > Fix retargeting of result in elementFromPoint and elementsFromPoint > > Currently elementFromPoint and elementsFromPoint are not per spec, and it may > return null incorrectly. This change adds retargeting of the result with > respect to the context object, and adds some tests that are similar to > elementFromPoint tests in WebKit, but with some corrected cases: > https://git.webkit.org/?p=WebKit-https.git;a=blob;f=LayoutTests/fast/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html;h=a8dc4da2430713521b9ba77c742db10397a8e638;hb=HEAD > > Spec: > https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin > > Bug: 759947 > Change-Id: I6aece5e9cc826124772c6ce13c806865055b2b9b > Reviewed-on: https://chromium-review.googlesource.com/808446 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Takayoshi Kochi <kochi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531139} TBR=kochi@chromium.org,dgozman@chromium.org,hayato@chromium.org,pfeldman@chromium.org,rakina@chromium.org Change-Id: Id62abd371d93627d3178b63ca189cecfe9ff44d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759947 Reviewed-on: https://chromium-review.googlesource.com/880264 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#531178}
jdm
pushed a commit
that referenced
this pull request
Mar 6, 2019
chromedriver doesn't allow changing Object.prototype to add enumerable
properties, but this test requires setting some values on
Object.prototype. When Object.prototype.a is set to:
{b: {c: 'on proto'}}
chromedriver fails with:
JavascriptErrorException: javascript error (500): Maximum call stack size exceeded
(Session info: chrome=72.0.3626.121)
Remote-end stacktrace:
#0 0x563ff3a32a59 <unknown>
#1 0x563ff39cb7f3 <unknown>
#2 0x563ff38fcd7c <unknown>
#3 0x563ff38ff78c <unknown>
#4 0x563ff38ff5f7 <unknown>
#5 0x563ff38ffbe7 <unknown>
#6 0x563ff38fff1b <unknown>
#7 0x563ff38a3f7a <unknown>
#8 0x563ff3899bf2 <unknown>
#9 0x563ff38a37b7 <unknown>
#10 0x563ff3899ac3 <unknown>
#11 0x563ff38782d2 <unknown>
#12 0x563ff3879112 <unknown>
#13 0x563ff39fe865 <unknown>
#14 0x563ff39ff32b <unknown>
#15 0x563ff39ff70c <unknown>
#16 0x563ff39d940a <unknown>
#17 0x563ff39ff997 <unknown>
#18 0x563ff39e9947 <unknown>
#19 0x563ff3a1a800 <unknown>
#20 0x563ff3a3c8be <unknown>
#21 0x7f3bf4545494 start_thread
#22 0x7f3bf2d58a8f clone
Ran 1 tests finished in 2.0 seconds.
• 0 ran as expected. 0 tests skipped.
• 1 tests had errors unexpectedly
Work around this problem by cleaning up the test environment so
Object.prototype no longer has the override by the time chromedriver
tries to inspect the test result.
While here, fix the other tests to use the t.add_cleanup() function
so they'll cleanup their test environment in case they exit in
some other way besides reaching t.done().
The underlying chromedriver issue is tracked upstream at
https://crbug.com/chromedriver/2555.
Bug: 934844
Change-Id: Id1b4ab2a908bfbc001e2a2d045eeec3ef01c24d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed in https://github.com/servo/servo/pulls/19173.