Conversation
foolip
reviewed
Oct 19, 2017
| WPT_ROOT=$(readlink -f $SCRIPT_DIR/../..) | ||
| cd $WPT_ROOT | ||
|
|
||
| mkdir -p ~/meta |
Member
There was a problem hiding this comment.
I don't understand the use of ~ here, where will the file actually end up? Is it in the wpt repo itself?
Contributor
Author
There was a problem hiding this comment.
It is generated in the $HOME/meta directory on the travis machine, and then finally gets uploaded to the "releases" part of the GitHub repo (if it works correctly :). But since it's not tagged I don't think it will show up as an actual release. But I hope we can still download it.
Member
There was a problem hiding this comment.
OK, as long as it's not in the wpt repo itself, I have no concerns. Let's see what happens :)
cdac203 to
828d350
Compare
foolip
approved these changes
Oct 19, 2017
This uploads a MANIFEST.json.gz file for every commit to master, so that we can build tooling that attempts to download that file as an initial manifest that can then have a rapid update rather than a slow build.
828d350 to
9ac76d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uploads a MANIFEST.json.gz file for every commit to master, so
that we can build tooling that attempts to download that file as an
initial manifest that can then have a rapid update rather than a slow
build.
This change is