Closed
Conversation
https://wicg.github.io/picture-in-picture/ The API is currently not working. It is mostly about implementing the shell: it exposes document.pictureInPictureEnabled, document.exitPictureInPicture(), and video.requestPictureInPicture(). It also adds the "picture-in-picture" feature policy. Everything is gated by the "PictureInPictureAPI" runtime feature. Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U8Apo-WLBm4/03sO4ITYAQAJ Change-Id: I64d8e17c6975017565c850afeeca19d94e9f9ceb Bug: 806249 Reviewed-on: https://chromium-review.googlesource.com/867915 Commit-Queue: Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#533310}
A misread of the spec made us skip out-of-flow boxes merging anonymous flex items. Only merge anonymous flex items which are truly box siblings. Adjusted the wpt tests accordingly. Fwiw, Firefox nightly now passes all of wpt/css/css-flexbox/anonymous-* Bug: 788379, 806151 Change-Id: I124740e5d2150becdcc03ded26773a69607e0bbb Reviewed-on: https://chromium-review.googlesource.com/895283 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#533440}
…r-webkit-182008 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=182008
…r-webkit-182077 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=182077
…r-webkit-181600 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=181600
This change renames public/interfaces to public/mojom and *_struct_traits_* to *_mojom_traits_* in //device. As a side effect the //device/vr/public/mojom directory was created to hold vr_service.mojom and //device/screen_orientation/public/interfaces was moved to //services/device/public/interfaces as the rest of that directory had already been moved to //services/device. Bug: 806965 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ieb8cf29107aaae89a9f616a864e079551da63768 Reviewed-on: https://chromium-review.googlesource.com/894142 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533528}
This patch implements the new CSSMathValue serialization algorithm [1]. As explained in the bug, this serialization is impossible to do by converting to CSSValues and then serializing them, so we have to implement this from scratch. We tried to make the code follow the spec algorithm as closely as possible for easier understanding/verification. [1] https://drafts.css-houdini.org/css-typed-om-1/#calc-serialization Bug: 803688 Change-Id: I48987d2b76b0bac55389a014588f3fe40aecf10a Reviewed-on: https://chromium-review.googlesource.com/896422 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533530}
…r-webkit-181087 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=181087
According to the shortest-serialization principle [1], values should be omitted if their omission wouldn't change the value of reparsing. As "1"/"on" is the default value for font-feature-settings, omit this when serializing, matching the behavior of Firefox. [1]: w3c/csswg-drafts#1564 Bug: 807744 Change-Id: Ieb8b86aa66aa303a82a895c42373177cf7f13d07 Reviewed-on: https://chromium-review.googlesource.com/896203 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533566}
The current spec says that it isn't nullable [1]. This CL also removes null check in client-navigate-worker.js. There is test coverage for null clientId in fetch-event.https.html so the explicit check here is not needed. You can find spec discussion in [2]. [1] w3c/ServiceWorker@8b483b0 [2] w3c/ServiceWorker#1266 Bug: 807818 Change-Id: I5ae4f866651931fee732516377b0fa155b0b5e22 Reviewed-on: https://chromium-review.googlesource.com/892762 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#533567}
…r-webkit-180939 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=180939
…r-webkit-181067 WebKit export of https://bugs.webkit.org/show_bug.cgi?id=181067
updated idl file and VTTScanner updated test cases and expected results https://w3c.github.io/webvtt/#dom-vttregion-lines w3c/webvtt#423 Bug: 755487 Change-Id: Ifd1ef26ede8cbc4f6bfe817aae9bce1191c18d24 Reviewed-on: https://chromium-review.googlesource.com/826666 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533586}
We had been using the same checks for both object and any Web IDL types to
determine if they were present, namely
!(member.IsEmpty() || member.IsNull() || member.IsUndefined())
However, both `null' and `undefined' are valid values for the any type, and
they should be considered distinct.
Add a separate check for any types without the "member.IsNull()" part of the
above one, so that one can pass `null' to an any member and get it back
instead of `undefined'.
Bug: 803448
Change-Id: I90dce8f0fc6c0f4d4764d724501a58cf26e92526
Reviewed-on: https://chromium-review.googlesource.com/895304
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#533601}
* The following features are not implemented widely. Enable their tests conditionally: - CSSStyleDeclaration.setPropertyValue - CSSStyleDeclaration.setPropertyPriority - HTMLInputElement.capture * The following features were removed from the specification. Remove tests. - HTMLElement.dropzone - HTMLElement.contextMenu Bug: 648828 Change-Id: Id76596fb50bc62166c1ae4b051ef46181b35b518 Reviewed-on: https://chromium-review.googlesource.com/896667 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533638}
jdm
pushed a commit
that referenced
this pull request
Mar 6, 2019
chromedriver doesn't allow changing Object.prototype to add enumerable
properties, but this test requires setting some values on
Object.prototype. When Object.prototype.a is set to:
{b: {c: 'on proto'}}
chromedriver fails with:
JavascriptErrorException: javascript error (500): Maximum call stack size exceeded
(Session info: chrome=72.0.3626.121)
Remote-end stacktrace:
#0 0x563ff3a32a59 <unknown>
#1 0x563ff39cb7f3 <unknown>
#2 0x563ff38fcd7c <unknown>
#3 0x563ff38ff78c <unknown>
#4 0x563ff38ff5f7 <unknown>
#5 0x563ff38ffbe7 <unknown>
#6 0x563ff38fff1b <unknown>
#7 0x563ff38a3f7a <unknown>
#8 0x563ff3899bf2 <unknown>
#9 0x563ff38a37b7 <unknown>
#10 0x563ff3899ac3 <unknown>
#11 0x563ff38782d2 <unknown>
#12 0x563ff3879112 <unknown>
#13 0x563ff39fe865 <unknown>
#14 0x563ff39ff32b <unknown>
#15 0x563ff39ff70c <unknown>
#16 0x563ff39d940a <unknown>
#17 0x563ff39ff997 <unknown>
#18 0x563ff39e9947 <unknown>
#19 0x563ff3a1a800 <unknown>
#20 0x563ff3a3c8be <unknown>
#21 0x7f3bf4545494 start_thread
#22 0x7f3bf2d58a8f clone
Ran 1 tests finished in 2.0 seconds.
• 0 ran as expected. 0 tests skipped.
• 1 tests had errors unexpectedly
Work around this problem by cleaning up the test environment so
Object.prototype no longer has the override by the time chromedriver
tries to inspect the test result.
While here, fix the other tests to use the t.add_cleanup() function
so they'll cleanup their test environment in case they exit in
some other way besides reaching t.done().
The underlying chromedriver issue is tracked upstream at
https://crbug.com/chromedriver/2555.
Bug: 934844
Change-Id: Id1b4ab2a908bfbc001e2a2d045eeec3ef01c24d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed in https://github.com/servo/servo/pulls/19922.