wai-aria: Remove redundant AX API assertions from two aria-modal tests.#7864
Merged
joanmarie merged 1 commit intoweb-platform-tests:masterfrom Oct 17, 2017
joanmarie:master
Merged
wai-aria: Remove redundant AX API assertions from two aria-modal tests.#7864joanmarie merged 1 commit intoweb-platform-tests:masterfrom joanmarie:master
joanmarie merged 1 commit intoweb-platform-tests:masterfrom
joanmarie:master
Conversation
The AXRole, AXSubrole, and AXRoleDescription are already being tested by the aria-modal="false" tests. In addition, what we really need to verify for AX API when aria-modal="true" is that the background content has been removed from the accessibility tree. The role details of other elements are irrelevant in performing that verification, and their inclusion introduces noise into the results.
halindrome
approved these changes
Oct 17, 2017
Contributor
halindrome
left a comment
There was a problem hiding this comment.
Yeah - there is no need to exercise that stuff in here.
Build PASSEDStarted: 2017-10-17 14:20:17 View more information about this build on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AXRole, AXSubrole, and AXRoleDescription are already being tested
by the aria-modal="false" tests. In addition, what we really need to
verify for AX API when aria-modal="true" is that the background content
has been removed from the accessibility tree. The role details of other
elements are irrelevant in performing that verification, and their
inclusion introduces noise into the results.