Fix log message in cni install.go file#56966
Merged
istio-testing merged 1 commit intoistio:masterfrom Jul 10, 2025
Merged
Conversation
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
keithmattix
approved these changes
Jul 10, 2025
Contributor
|
Thanks for the catch! |
howardjohn
approved these changes
Jul 10, 2025
jaellio
approved these changes
Jul 10, 2025
Collaborator
|
In response to a cherrypick label: new pull request created: #56968 |
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: (21 commits) feat: skip queue for status updates on gw (istio#56962) Automator: update proxy@master in istio/istio@master (istio#56993) Automator: update proxy@master in istio/istio@master (istio#56990) Change host iptables rule addition from Append to Insert to ensure Istio's rules take precedence (istio#56414) support specifying proxy admin port for describe (istio#56854) support reset log level or stack trace level separately for admin log (istio#56642) improve example format for istioctl x describe (istio#56951) Automator: update ztunnel@master in istio/istio@master (istio#56971) Remove flaky test (istio#56919) fix: fixes test which fails for distroless (istio#56965) Automator: update proxy@master in istio/istio@master (istio#56969) Ambient Multicluster SplitHorizon WDS Implementation (istio#56844) Fix log message in cni install.go file (istio#56966) add env vars for ip auto allocate ipv4/v6 cidr prefixes (istio#56276) Update BASE_VERSION to master-2025-07-10T19-01-16 (istio#56967) Add AllowCRDsMismatch parameter to gateway conformance options. (istio#56945) Revert "feat: represent revision tags using services (istio#56851)" (istio#56941) Automator: update proxy@master in istio/istio@master (istio#56954) Automator: update istio/client-go@master dependency in istio/istio@master (istio#56911) Automator: update common-files@master in istio/istio@master (istio#56952) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the following log in the istio-cni logs.
Looks like the log message was accidentally committed with a developer's name.