Skip to content

feat: represent revision tags using services#56851

Merged
istio-testing merged 2 commits intoistio:masterfrom
german1608:feat/use-services-for-mwh-replacement
Jul 7, 2025
Merged

feat: represent revision tags using services#56851
istio-testing merged 2 commits intoistio:masterfrom
german1608:feat/use-services-for-mwh-replacement

Conversation

@german1608
Copy link
Copy Markdown
Contributor

@german1608 german1608 commented Jul 1, 2025 •
edited by istio-policy-bot
Loading

Reattempting #56141

Commit 9d56196 is the fix. I don't like to manually delete the revision tag service but it seems like we are doing it anyways for mutatingwebhookconfigurations

@german1608 german1608 requested review from a team as code owners July 1, 2025 19:15
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 1, 2025
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 1, 2025

Hi @german1608. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@keithmattix
Copy link
Copy Markdown
Contributor

keithmattix commented Jul 1, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 1, 2025
Stevenjin8
Stevenjin8 reviewed Jul 1, 2025
View reviewed changes
@Stevenjin8
Copy link
Copy Markdown
Contributor

Stevenjin8 commented Jul 1, 2025 •
edited
Loading

@german1608 Just for my understanding, we are ditching the tag CRD idea?

EDIT: sorry didnt see the revert

@german1608
Copy link
Copy Markdown
Contributor Author

german1608 commented Jul 3, 2025

Could I have a review on this PR please?

@keithmattix
Copy link
Copy Markdown
Contributor

keithmattix commented Jul 3, 2025

Can you manually run one of the failing test from postsubmit with /test __

@german1608
Copy link
Copy Markdown
Contributor Author

german1608 commented Jul 3, 2025

/test integ-basic-arm64_istio_postsubmit

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 3, 2025

@german1608: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test bookinfo-build

/test gencheck

/test integ-ambient

/test integ-ambient-ipv6

/test integ-basic-arm64

/test integ-cni

/test integ-distroless

/test integ-ds

/test integ-helm

/test integ-ipv6

/test integ-pilot

/test integ-pilot-istiodremote

/test integ-pilot-istiodremote-mc

/test integ-pilot-multicluster

/test integ-security

/test integ-security-istiodremote

/test integ-security-multicluster

/test integ-telemetry

/test integ-telemetry-discovery

/test integ-telemetry-istiodremote

/test integ-telemetry-mc

/test lint

/test macbuildcheck

/test release-notes

/test release-test

/test unit-tests

/test unit-tests-arm64

/test windowsbuildcheck

The following commands are available to trigger optional jobs:

/test benchmark

/test experimental-tracing

/test govulncheck

/test integ-ambient-calico

/test integ-ambient-dual

/test integ-ambient-mc

/test integ-assertion

Use /test all to run the following jobs that were automatically triggered:

gencheck_istio

integ-ambient-ipv6_istio

integ-ambient-mc_istio

integ-ambient_istio

integ-basic-arm64_istio

integ-cni_istio

integ-distroless_istio

integ-ds_istio

integ-helm_istio

integ-ipv6_istio

integ-pilot-istiodremote-mc_istio

integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio

integ-pilot_istio

integ-security-istiodremote_istio

integ-security-multicluster_istio

integ-security_istio

integ-telemetry-discovery_istio

integ-telemetry-istiodremote_istio

integ-telemetry-mc_istio

integ-telemetry_istio

lint_istio

macbuildcheck_istio

release-notes_istio

release-test_istio

unit-tests-arm64_istio

unit-tests_istio

windowsbuildcheck_istio
Details

In response to this:

/test integ-basic-arm64_istio_postsubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Stevenjin8
Copy link
Copy Markdown
Contributor

Stevenjin8 commented Jul 3, 2025

/test integ-basic-arm64

@german1608
Copy link
Copy Markdown
Contributor Author

german1608 commented Jul 7, 2025

/test gencheck

@istio-testing istio-testing merged commit 097a180 into istio:master Jul 7, 2025
30 checks passed
keithmattix added a commit that referenced this pull request Jul 9, 2025
@keithmattix
Revert "feat: represent revision tags using services (#56851)"
a6c8b4d 
This reverts commit 097a180.
@keithmattix keithmattix mentioned this pull request Jul 9, 2025
Merged
istio-testing pushed a commit that referenced this pull request Jul 10, 2025
@keithmattix
Revert "feat: represent revision tags using services (#56851)" (#56941)
64ff3c1 
This reverts commit 097a180.
@german1608 german1608 mentioned this pull request Jul 10, 2025
Merged
fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025
Automator: merge upstream changes to openshift-service-mesh/istio@master
3d09902 
* upstream/master:
  set VERSION on master to 1.28 (istio#56902)
  Automator: update ztunnel@master in istio/istio@master (istio#56900)
  Move Alpha Gateway API Inference Extension support to master (istio#56845)
  Support native sidecar by default (istio#56428)
  feat: represent revision tags using services (istio#56851)
fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025
Automator: merge upstream changes to openshift-service-mesh/istio@master
3a3260c 
* upstream/master: (21 commits)
  feat: skip queue for status updates on gw (istio#56962)
  Automator: update proxy@master in istio/istio@master (istio#56993)
  Automator: update proxy@master in istio/istio@master (istio#56990)
  Change host iptables rule addition from Append to Insert to ensure Istio's rules take precedence (istio#56414)
  support specifying proxy admin port for describe (istio#56854)
  support reset log level or stack trace level separately for admin log (istio#56642)
  improve example format for istioctl x describe (istio#56951)
  Automator: update ztunnel@master in istio/istio@master (istio#56971)
  Remove flaky test (istio#56919)
  fix: fixes test which fails for distroless (istio#56965)
  Automator: update proxy@master in istio/istio@master (istio#56969)
  Ambient Multicluster SplitHorizon WDS Implementation (istio#56844)
  Fix log message in cni install.go file (istio#56966)
  add env vars for ip auto allocate ipv4/v6 cidr prefixes (istio#56276)
  Update BASE_VERSION to master-2025-07-10T19-01-16 (istio#56967)
  Add AllowCRDsMismatch parameter to gateway conformance options. (istio#56945)
  Revert "feat: represent revision tags using services (istio#56851)" (istio#56941)
  Automator: update proxy@master in istio/istio@master (istio#56954)
  Automator: update istio/client-go@master dependency in istio/istio@master (istio#56911)
  Automator: update common-files@master in istio/istio@master (istio#56952)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Stevenjin8 Stevenjin8 Stevenjin8 left review comments

@therealmitchconnors therealmitchconnors therealmitchconnors approved these changes

@keithmattix keithmattix keithmattix approved these changes

Assignees

No one assigned

Labels

area/ambient Issues related to ambient mesh area/environments area/test and release area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@german1608 @istio-testing @keithmattix @Stevenjin8 @therealmitchconnors @istio-policy-bot