Skip to content

Remove flaky test#56919

Merged
istio-testing merged 3 commits intoistio:masterfrom
Stevenjin8:test/flaky-multicluster-test
Jul 11, 2025
Merged

Remove flaky test#56919
istio-testing merged 3 commits intoistio:masterfrom
Stevenjin8:test/flaky-multicluster-test

Conversation

@Stevenjin8
Copy link
Copy Markdown
Contributor

@Stevenjin8 Stevenjin8 commented Jul 8, 2025 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

Its hard to consistently test "action A will only cause this event" because event could have occurred before A and there is no way of saying "wait until all events propagate/KRT state is stable, then run A".

@Stevenjin8 Stevenjin8 requested a review from a team as a code owner July 8, 2025 18:50
@istio-policy-bot istio-policy-bot added area/ambient Issues related to ambient mesh area/test and release release-notes-none Indicates a PR that does not require release notes. labels Jul 8, 2025
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2025
@Stevenjin8 Stevenjin8 force-pushed the test/flaky-multicluster-test branch from f464d1b to 08295e6 Compare July 8, 2025 19:50
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 11, 2025
@Stevenjin8 Stevenjin8 force-pushed the test/flaky-multicluster-test branch from 08295e6 to 16a5602 Compare July 11, 2025 18:10
@Stevenjin8 Stevenjin8 requested a review from a team as a code owner July 11, 2025 18:10
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2025
@Stevenjin8
Copy link
Copy Markdown
Contributor Author

Stevenjin8 commented Jul 11, 2025

/retest

@istio-testing istio-testing merged commit 026c619 into istio:master Jul 11, 2025
31 checks passed
@Stevenjin8 Stevenjin8 added the cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch label Jul 11, 2025
@Stevenjin8
Copy link
Copy Markdown
Contributor Author

Stevenjin8 commented Jul 11, 2025

/cherrypick release-1.27

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 11, 2025

In response to a cherrypick label: #56919 failed to apply on top of branch "release-1.27":

Applying: Remove flaky test
Using index info to reconstruct a base tree...
M	pilot/pkg/serviceregistry/kube/controller/ambient/ambientindex_multicluster_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/kube/controller/ambient/ambientindex_multicluster_test.go
CONFLICT (content): Merge conflict in pilot/pkg/serviceregistry/kube/controller/ambient/ambientindex_multicluster_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove flaky test

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 11, 2025

In response to a cherrypick label: new issue created for failed cherrypick: #56980

@istio-testing istio-testing mentioned this pull request Jul 11, 2025
Closed
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 11, 2025

@Stevenjin8: #56919 failed to apply on top of branch "release-1.27":

Applying: Remove flaky test
Using index info to reconstruct a base tree...
M	pilot/pkg/serviceregistry/kube/controller/ambient/ambientindex_multicluster_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/kube/controller/ambient/ambientindex_multicluster_test.go
CONFLICT (content): Merge conflict in pilot/pkg/serviceregistry/kube/controller/ambient/ambientindex_multicluster_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove flaky test
Details

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 11, 2025

@Stevenjin8: new issue created for failed cherrypick: #56981

Details

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing mentioned this pull request Jul 11, 2025
Closed
Stevenjin8 added a commit to Stevenjin8/istio that referenced this pull request Jul 11, 2025
@Stevenjin8
Remove flaky test (istio#56919)
4da7251 
* Remove flaky test

* Reduce more flakes with proper locking

* lint
Stevenjin8 added a commit to Stevenjin8/istio that referenced this pull request Jul 22, 2025
@Stevenjin8
Remove flaky test (istio#56919)
4a3cf18 
* Remove flaky test

* Reduce more flakes with proper locking

* lint
istio-testing pushed a commit that referenced this pull request Jul 22, 2025
@Stevenjin8
Remove flaky test (#56919) (#57101)
8d58874 
* Remove flaky test

* Reduce more flakes with proper locking

* lint
fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025
Automator: merge upstream changes to openshift-service-mesh/istio@master
3a3260c 
* upstream/master: (21 commits)
  feat: skip queue for status updates on gw (istio#56962)
  Automator: update proxy@master in istio/istio@master (istio#56993)
  Automator: update proxy@master in istio/istio@master (istio#56990)
  Change host iptables rule addition from Append to Insert to ensure Istio's rules take precedence (istio#56414)
  support specifying proxy admin port for describe (istio#56854)
  support reset log level or stack trace level separately for admin log (istio#56642)
  improve example format for istioctl x describe (istio#56951)
  Automator: update ztunnel@master in istio/istio@master (istio#56971)
  Remove flaky test (istio#56919)
  fix: fixes test which fails for distroless (istio#56965)
  Automator: update proxy@master in istio/istio@master (istio#56969)
  Ambient Multicluster SplitHorizon WDS Implementation (istio#56844)
  Fix log message in cni install.go file (istio#56966)
  add env vars for ip auto allocate ipv4/v6 cidr prefixes (istio#56276)
  Update BASE_VERSION to master-2025-07-10T19-01-16 (istio#56967)
  Add AllowCRDsMismatch parameter to gateway conformance options. (istio#56945)
  Revert "feat: represent revision tags using services (istio#56851)" (istio#56941)
  Automator: update proxy@master in istio/istio@master (istio#56954)
  Automator: update istio/client-go@master dependency in istio/istio@master (istio#56911)
  Automator: update common-files@master in istio/istio@master (istio#56952)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithmattix keithmattix keithmattix approved these changes

Assignees

No one assigned

Labels

area/ambient Issues related to ambient mesh area/test and release cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Stevenjin8 @istio-testing @keithmattix @istio-policy-bot