Skip to content

feat: skip queue for status updates on gw#56962

Merged
istio-testing merged 2 commits intoistio:masterfrom
mmerrill3:feature/queue-filter-deploymentcontroller
Jul 13, 2025
Merged

feat: skip queue for status updates on gw#56962
istio-testing merged 2 commits intoistio:masterfrom
mmerrill3:feature/queue-filter-deploymentcontroller

Conversation

@mmerrill3
Copy link
Copy Markdown
Contributor

@mmerrill3 mmerrill3 commented Jul 10, 2025 •
edited
Loading

Please provide a description of this PR:

During event handling for the deploymentcontroller, when the gateway informer handles events, and the event is an update, and the labels and annotations do not chnage, and the generation is the same (no spec update), do not enqueue for reconciliation. Fixes #56795

@mmerrill3
feat: skip queue for status updates on gw (istio#56795)
8aad60c 
Signed-off-by: Michael Merrill <mike.merrill@alkami.com>
@mmerrill3 mmerrill3 requested a review from a team as a code owner July 10, 2025 16:34
@istio-policy-bot istio-policy-bot added area/perf and scalability release-notes-none Indicates a PR that does not require release notes. labels Jul 10, 2025
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Jul 10, 2025
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 10, 2025

Hi @mmerrill3. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmerrill3 mmerrill3 changed the title feat: skip queue for status updates on gw (#56795) feat: skip queue for status updates on gw (fixes #56795) Jul 10, 2025
howardjohn
howardjohn approved these changes Jul 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Jul 12, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 12, 2025
@zirain zirain changed the title feat: skip queue for status updates on gw (fixes #56795) feat: skip queue for status updates on gw Jul 12, 2025
@mmerrill3
chore: fix lint issue
255ac4c 
Signed-off-by: Michael Merrill <mike.merrill@alkami.com>
@istio-testing istio-testing merged commit ea376d3 into istio:master Jul 13, 2025
31 checks passed
@keithmattix
Copy link
Copy Markdown
Contributor

keithmattix commented Jul 17, 2025 •
edited
Loading

Should this and the flake fix be be cherry-picked to 1.27?

@ramaraochavali
Copy link
Copy Markdown
Contributor

ramaraochavali commented Jul 18, 2025

I think so

@keithmattix keithmattix added the cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch label Jul 18, 2025
@keithmattix
Copy link
Copy Markdown
Contributor

keithmattix commented Jul 18, 2025

/cherry-pick release-1.27

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 18, 2025

@keithmattix: new pull request created: #57061

Details

In response to this:

/cherry-pick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing mentioned this pull request Jul 18, 2025
Merged
fjglira pushed a commit to fjglira/istio that referenced this pull request Sep 26, 2025
Automator: merge upstream changes to openshift-service-mesh/istio@master
3a3260c 
* upstream/master: (21 commits)
  feat: skip queue for status updates on gw (istio#56962)
  Automator: update proxy@master in istio/istio@master (istio#56993)
  Automator: update proxy@master in istio/istio@master (istio#56990)
  Change host iptables rule addition from Append to Insert to ensure Istio's rules take precedence (istio#56414)
  support specifying proxy admin port for describe (istio#56854)
  support reset log level or stack trace level separately for admin log (istio#56642)
  improve example format for istioctl x describe (istio#56951)
  Automator: update ztunnel@master in istio/istio@master (istio#56971)
  Remove flaky test (istio#56919)
  fix: fixes test which fails for distroless (istio#56965)
  Automator: update proxy@master in istio/istio@master (istio#56969)
  Ambient Multicluster SplitHorizon WDS Implementation (istio#56844)
  Fix log message in cni install.go file (istio#56966)
  add env vars for ip auto allocate ipv4/v6 cidr prefixes (istio#56276)
  Update BASE_VERSION to master-2025-07-10T19-01-16 (istio#56967)
  Add AllowCRDsMismatch parameter to gateway conformance options. (istio#56945)
  Revert "feat: represent revision tags using services (istio#56851)" (istio#56941)
  Automator: update proxy@master in istio/istio@master (istio#56954)
  Automator: update istio/client-go@master dependency in istio/istio@master (istio#56911)
  Automator: update common-files@master in istio/istio@master (istio#56952)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

No one assigned

Labels

area/perf and scalability cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gateway deployer runs deployment loop on each Gateway status update

6 participants

@mmerrill3 @istio-testing @howardjohn @keithmattix @ramaraochavali @istio-policy-bot