Conversation
Krt places a number of un-checked requirements on collections. This PR introduces a new knob to turn on assertions to be used during development. IT IS OFF for production
|
Skipping CI for Draft Pull Request. |
|
@howardjohn: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| ) | ||
|
|
||
| // EnableAssertions, if true, will enable assertions. These typically are violations of the krt collection requirements. | ||
| const EnableAssertions = false |
There was a problem hiding this comment.
How/where does one enable these assertions?
|
In response to a cherrypick label: #56510 failed to apply on top of branch "release-1.26": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #56516 |
Krt places a number of un-checked requirements on collections. This PR introduces a new knob to turn on assertions to be used during development. IT IS OFF for production (cherry picked from commit d8748b7)
* upstream/master: (28 commits) Automator: update common-files@master in istio/istio@master (istio#56545) Automator: update proxy@master in istio/istio@master (istio#56544) Automator: update go-control-plane in istio/istio@master (istio#56543) Automator: update proxy@master in istio/istio@master (istio#56540) Automator: update ztunnel@master in istio/istio@master (istio#56532) Ambient: In ambient index, filter configs by revision (istio#56477) Automator: update istio/client-go@master dependency in istio/istio@master (istio#56539) Automator: update proxy@master in istio/istio@master (istio#56538) Automator: update common-files@master in istio/istio@master (istio#56537) optimization: allow for lazy sidecar initialization (istio#47221) static collection eager indexes (istio#56530) fix typo in flag (istio#56534) feat: enable support for proxy protocol on status port (istio#55986) remove finding of pods by IP (istio#56502) Automator: update proxy@master in istio/istio@master (istio#56528) migrate file monitor to krt (istio#55970) Automator: update istio/client-go@master dependency in istio/istio@master (istio#56525) Automator: update ztunnel@master in istio/istio@master (istio#56518) Fix crash in merging http routes (istio#56499) krt: add assertions (istio#56510) ...
Krt places a number of un-checked requirements on collections.
This PR introduces a new knob to turn on assertions to be used during
development. IT IS OFF for production.
For the record, I had two tests that fail these assertions:
Additionally, Itried to make a wrapper to allow safe merging:
However, this does not work due to MapCollection requiring the input and output key to be the same. I added an assertion to verify this.