Ambient: In ambient index, filter configs by revision#56477
Merged
istio-testing merged 3 commits intoistio:masterfrom Jun 6, 2025
Merged
Ambient: In ambient index, filter configs by revision#56477istio-testing merged 3 commits intoistio:masterfrom
istio-testing merged 3 commits intoistio:masterfrom
Conversation
howardjohn
reviewed
Jun 3, 2025
Member
howardjohn
left a comment
There was a problem hiding this comment.
lgtm aside from some comments
| remoteClientConfigOverrides: options.RemoteClientConfigOverrides, | ||
| } | ||
|
|
||
| filter := kclient.Filter{ |
Member
There was a problem hiding this comment.
I think we don't want this for Gateways. A user will set a rev on a gateway to make it programmed by istiod-A, but istiod-B needs to know about it.
|
|
||
| filter := kclient.Filter{ | ||
| ObjectFilter: options.Client.ObjectFilter(), | ||
| ObjectFilter: kubetypes.ComposeFilters(options.Client.ObjectFilter(), a.inRevision), |
Member
There was a problem hiding this comment.
This should only be on configuration objects to maintain consistency. So not Services seems to be the only one violating this currently. Maybe renaming filter to make that clear would help avoid future mis-use as well
Contributor
|
/retest |
Collaborator
|
@vikaschoudhary16: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
howardjohn
approved these changes
Jun 6, 2025
vikaschoudhary16
added a commit
to vikaschoudhary16/istio
that referenced
this pull request
Jun 18, 2025
* In ambient index, filter configs by revision * release notes * Address feedback Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
Member
|
@howardjohn is this safe to backport? |
istio-testing
pushed a commit
that referenced
this pull request
Jun 19, 2025
…56477) (#56689) * Ambient: In ambient index, filter configs by revision (#56477) * In ambient index, filter configs by revision * release notes * Address feedback Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com> * Update releasenotes/notes/56477.yaml --------- Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com> Co-authored-by: Daniel Hawton <daniel@hawton.org>
vikaschoudhary16
added a commit
to vikaschoudhary16/istio
that referenced
this pull request
Jun 20, 2025
…stio#56477) (istio#56689) * Ambient: In ambient index, filter configs by revision (istio#56477) * In ambient index, filter configs by revision * release notes * Address feedback Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com> * Update releasenotes/notes/56477.yaml --------- Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com> Co-authored-by: Daniel Hawton <daniel@hawton.org> Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com>
istio-testing
pushed a commit
that referenced
this pull request
Jun 20, 2025
…56477) (#56689) (#56713) * Ambient: In ambient index, filter configs by revision (#56477) * In ambient index, filter configs by revision * release notes * Address feedback * Update releasenotes/notes/56477.yaml --------- Signed-off-by: Vikas Choudhary (vikasc) <choudharyvikas16@gmail.com> Co-authored-by: Daniel Hawton <daniel@hawton.org>
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: (28 commits) Automator: update common-files@master in istio/istio@master (istio#56545) Automator: update proxy@master in istio/istio@master (istio#56544) Automator: update go-control-plane in istio/istio@master (istio#56543) Automator: update proxy@master in istio/istio@master (istio#56540) Automator: update ztunnel@master in istio/istio@master (istio#56532) Ambient: In ambient index, filter configs by revision (istio#56477) Automator: update istio/client-go@master dependency in istio/istio@master (istio#56539) Automator: update proxy@master in istio/istio@master (istio#56538) Automator: update common-files@master in istio/istio@master (istio#56537) optimization: allow for lazy sidecar initialization (istio#47221) static collection eager indexes (istio#56530) fix typo in flag (istio#56534) feat: enable support for proxy protocol on status port (istio#55986) remove finding of pods by IP (istio#56502) Automator: update proxy@master in istio/istio@master (istio#56528) migrate file monitor to krt (istio#55970) Automator: update istio/client-go@master dependency in istio/istio@master (istio#56525) Automator: update ztunnel@master in istio/istio@master (istio#56518) Fix crash in merging http routes (istio#56499) krt: add assertions (istio#56510) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Unlike sidecar mode, ambient index does not filter configs by revision. For example if istiod is revision
stableand config CRs such as authz policy arecanaryrevision labelled, still these configs are in ambient index and pushed to ztunnel.This PR is adding the config filtering by revision.