migrate file monitor to krt#55970
Merged
istio-testing merged 6 commits intoistio:masterfrom Jun 5, 2025
Merged
Conversation
808d538 to
fd1a2b4
Compare
sschepens
commented
Apr 16, 2025
|
|
||
| // Defer starting the file monitor until after the service is created. | ||
| s.addStartFunc("file monitor", func(stop <-chan struct{}) error { | ||
| fileMonitor.Start(stop) |
Contributor
Author
There was a problem hiding this comment.
previously this controller would only start monitoring files when the server actually started, we are losing this with the new implementation (KRT implementation does not allow for a delayed start), but we could delay the creation of collections if it's necessary.
howardjohn
reviewed
Apr 17, 2025
Member
howardjohn
left a comment
There was a problem hiding this comment.
Nice! only had a chance to give it a brief look but looking good
sschepens
commented
Apr 21, 2025
06c7225 to
2882dc1
Compare
6ae1d0d to
06a9bcc
Compare
06a9bcc to
b402846
Compare
Contributor
Author
|
@howardjohn could you give this another look? I've made some changes to only use a single |
stevenctl
reviewed
May 1, 2025
stevenctl
reviewed
May 1, 2025
Contributor
stevenctl
left a comment
There was a problem hiding this comment.
LGTM but have 1 question
Contributor
Author
|
@howardjohn could you give this another look please? |
howardjohn
approved these changes
Jun 5, 2025
Member
howardjohn
left a comment
There was a problem hiding this comment.
🔥
Sorry lost track of this one
irenezhong2861
pushed a commit
to irenezhong2861/istio
that referenced
this pull request
Jun 5, 2025
* migrate file monitor to krt * implment get & list by namespace * fixes and tests * fix event handling * fix file controller test * use single FileCollection for efficiency
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: (28 commits) Automator: update common-files@master in istio/istio@master (istio#56545) Automator: update proxy@master in istio/istio@master (istio#56544) Automator: update go-control-plane in istio/istio@master (istio#56543) Automator: update proxy@master in istio/istio@master (istio#56540) Automator: update ztunnel@master in istio/istio@master (istio#56532) Ambient: In ambient index, filter configs by revision (istio#56477) Automator: update istio/client-go@master dependency in istio/istio@master (istio#56539) Automator: update proxy@master in istio/istio@master (istio#56538) Automator: update common-files@master in istio/istio@master (istio#56537) optimization: allow for lazy sidecar initialization (istio#47221) static collection eager indexes (istio#56530) fix typo in flag (istio#56534) feat: enable support for proxy protocol on status port (istio#55986) remove finding of pods by IP (istio#56502) Automator: update proxy@master in istio/istio@master (istio#56528) migrate file monitor to krt (istio#55970) Automator: update istio/client-go@master dependency in istio/istio@master (istio#56525) Automator: update ztunnel@master in istio/istio@master (istio#56518) Fix crash in merging http routes (istio#56499) krt: add assertions (istio#56510) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Migrated file monitor based config controller to KRT, taking advantage of #55337
This allows deleting the old file monitor implmentation, reducing the amount of code to maintain.