krt: implement folder based collections#55337
Merged
istio-testing merged 7 commits intoistio:masterfrom Apr 15, 2025
Merged
Conversation
a15b45c to
dd255d9
Compare
dd255d9 to
18e0785
Compare
18e0785 to
59f6770
Compare
Contributor
|
not stale |
ilrudie
reviewed
Apr 9, 2025
Contributor
ilrudie
left a comment
There was a problem hiding this comment.
mostly lgtm. do we still want to go with this?
| t test.Failer | ||
| } | ||
|
|
||
| // CreateObject is a stub |
Contributor
There was a problem hiding this comment.
No longer a stub
Suggested change
| // CreateObject is a stub |
Member
Author
Yes I think we need this for parity with existing Istio which allows reading files |
ilrudie
approved these changes
Apr 15, 2025
This was referenced Apr 16, 2025
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: Automator: update ztunnel@master in istio/istio@master (istio#55950) Automator: update proxy@master in istio/istio@master (istio#55938) gateway: refactor event handling (istio#55758) initial ClusterTrustBundle v1alpha1 support (istio#55592) gateway: add support for using workload certificate (istio#55899) krt: implement folder based collections (istio#55337) support envVarFrom in istiod chart (istio#55872) pilot: fix verified certificate when mtls and referencegrants (istio#55859) default maxconnectionstoacceptpersocketevent to a sensible value (istio#55817)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives us the ability to register a collection based on a folder. The intent is to allow us to be able to have the same config as
istio/pilot/pkg/bootstrap/configcontroller.go
Line 258 in b59d3f5