default maxconnectionstoacceptpersocketevent to a sensible value#55817
Merged
istio-testing merged 3 commits intoistio:masterfrom Apr 15, 2025
Merged
default maxconnectionstoacceptpersocketevent to a sensible value#55817istio-testing merged 3 commits intoistio:masterfrom
istio-testing merged 3 commits intoistio:masterfrom
Conversation
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
dgn
reviewed
Apr 11, 2025
Contributor
dgn
left a comment
There was a problem hiding this comment.
LGTM and it appears to me (without knowing the details) that this is a sensible default but IMO we will need at least a release note to capture that this default value was changed.
pilot/pkg/features/pilot.go
Outdated
| EnableGatewayAPIManualDeployment = env.Register("ENABLE_GATEWAY_API_MANUAL_DEPLOYMENT", true, | ||
| "If true, allows users to bind Gateway API resources to existing gateway deployments.").Get() | ||
|
|
||
| MaxConnectionsToAcceptPerSocketEvent = func() *wrapperspb.UInt32Value { |
Contributor
There was a problem hiding this comment.
nit: maybe move the proto-specific part to pilot/pkg/networking/core/listener.go. will keep the imports in features pkg tidy
pilot/pkg/features/pilot.go
Outdated
|
|
||
| MaxConnectionsToAcceptPerSocketEvent = func() *wrapperspb.UInt32Value { | ||
| v := env.Register("MAX_CONNECTIONS_PER_SOCKET_EVENT_LOOP", 1, | ||
| "The maximum number of connections to accept from the kernel per socket event.").Get() |
Contributor
There was a problem hiding this comment.
Suggested change
| "The maximum number of connections to accept from the kernel per socket event.").Get() | |
| "The maximum number of connections to accept from the kernel per socket event. Set this to '0' to accept unlimited connections.").Get() |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Contributor
Author
|
Good call on release notes. Added. |
Contributor
Author
|
@howardjohn @hzxuzhonghu can you please review as well? |
dgn
approved these changes
Apr 15, 2025
hzxuzhonghu
approved these changes
Apr 15, 2025
fjglira
pushed a commit
to fjglira/istio
that referenced
this pull request
Sep 26, 2025
* upstream/master: Automator: update ztunnel@master in istio/istio@master (istio#55950) Automator: update proxy@master in istio/istio@master (istio#55938) gateway: refactor event handling (istio#55758) initial ClusterTrustBundle v1alpha1 support (istio#55592) gateway: add support for using workload certificate (istio#55899) krt: implement folder based collections (istio#55337) support envVarFrom in istiod chart (istio#55872) pilot: fix verified certificate when mtls and referencegrants (istio#55859) default maxconnectionstoacceptpersocketevent to a sensible value (istio#55817)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See envoyproxy/envoy#38999 and envoyproxy/envoy#19103 (comment)
I think compatibility version is not needed as it is most sensible default but if there are concerns I can add