Skip to content

listener: advise setting max_connections_accept_per_socket_event#38999

Merged
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
botengyao:update_max_connection_per_socket
Apr 16, 2025
Merged

listener: advise setting max_connections_accept_per_socket_event#38999
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
botengyao:update_max_connection_per_socket

Conversation

@botengyao
Copy link
Copy Markdown
Member

@botengyao botengyao commented Apr 3, 2025

setting max_connections_accept_per_socket_event value will limit the cost of per event and benefit overload management without impact of the performance.

Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

Signed-off-by: Boteng Yao <boteng@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #38999 was opened by botengyao.

see: more, trace.

Signed-off-by: Boteng Yao <boteng@google.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented Apr 14, 2025

ping @wbpcode

Copy link
Copy Markdown
Contributor

@yanavlasov yanavlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a comment change, without any API changes, so skipping API review for this one.

@yanavlasov yanavlasov merged commit 0a1293b into envoyproxy:main Apr 16, 2025
24 of 25 checks passed
oconnorkyle pushed a commit to oconnorkyle/envoy that referenced this pull request Apr 23, 2025
…oyproxy#38999)

setting max_connections_accept_per_socket_event value will limit the
cost of per event and benefit overload management without impact of the
performance.

Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Kyle O'Connor <oconnorkyle@google.com>
oconnorkyle pushed a commit to oconnorkyle/envoy that referenced this pull request Apr 23, 2025
…oyproxy#38999)

setting max_connections_accept_per_socket_event value will limit the
cost of per event and benefit overload management without impact of the
performance.

Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

---------

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Kyle O'Connor <oconnorkyle@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants