Skip to content

126/krt assert#56629

Merged
istio-testing merged 1 commit intoistio:release-1.26from
howardjohn:126/krt-assert
Jun 16, 2025
Merged

126/krt assert#56629
istio-testing merged 1 commit intoistio:release-1.26from
howardjohn:126/krt-assert

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Jun 13, 2025 •
edited
Loading

Krt places a number of un-checked requirements on collections.

This PR introduces a new knob to turn on assertions to be used during
development. IT IS OFF for production

(cherry picked from commit howardjohn@d8748b7)

@howardjohn
krt: add assertions (istio#56510)
6c44440 
Krt places a number of un-checked requirements on collections.

This PR introduces a new knob to turn on assertions to be used during
development. IT IS OFF for production

(cherry picked from commit d8748b7)
@howardjohn howardjohn added release-notes-none Indicates a PR that does not require release notes. cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch labels Jun 13, 2025
@howardjohn howardjohn requested review from a team as code owners June 13, 2025 12:54
@howardjohn howardjohn requested a review from a team June 13, 2025 12:54
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 13, 2025
@howardjohn howardjohn removed the cherrypick/release-1.26 Set this label on a PR to auto-merge it to the release-1.26 branch label Jun 13, 2025
@howardjohn howardjohn changed the base branch from master to release-1.26 June 13, 2025 15:39
@howardjohn howardjohn requested a review from a team June 13, 2025 15:39
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 13, 2025
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 13, 2025 •
edited
Loading

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-basic-arm64_istio 6c44440 link true /test integ-basic-arm64
integ-security-istiodremote_istio 6c44440 link true /test integ-security-istiodremote
integ-ambient_istio 6c44440 link true /test integ-ambient
integ-ambient-ipv6_istio 6c44440 link true /test integ-ambient-ipv6
integ-ipv6_istio 6c44440 link true /test integ-ipv6
gencheck_istio 6c44440 link true /test gencheck
integ-pilot-multicluster_istio 6c44440 link true /test integ-pilot-multicluster
integ-ds_istio 6c44440 link true /test integ-ds
integ-pilot-istiodremote-mc_istio 6c44440 link true /test integ-pilot-istiodremote-mc
integ-distroless_istio 6c44440 link true /test integ-distroless
integ-security_istio 6c44440 link true /test integ-security
windowsbuildcheck_istio 6c44440 link true /test windowsbuildcheck
integ-pilot_istio 6c44440 link true /test integ-pilot
integ-telemetry-discovery_istio 6c44440 link true /test integ-telemetry-discovery
integ-telemetry-istiodremote_istio 6c44440 link true /test integ-telemetry-istiodremote
integ-telemetry_istio 6c44440 link true /test integ-telemetry
integ-telemetry-mc_istio 6c44440 link true /test integ-telemetry-mc
integ-pilot-istiodremote_istio 6c44440 link true /test integ-pilot-istiodremote
integ-cni_istio 6c44440 link true /test integ-cni
unit-tests-arm64_istio 6c44440 link true /test unit-tests-arm64
lint_istio 6c44440 link true /test lint
macbuildcheck_istio 6c44440 link true /test macbuildcheck
release-notes_istio 6c44440 link true /test release-notes
release-test_istio 6c44440 link true /test release-test
integ-security-multicluster_istio 6c44440 link true /test integ-security-multicluster
unit-tests_istio 6c44440 link true /test unit-tests
integ-ambient-mc_istio 6c44440 link false /test integ-ambient-mc
integ-helm_istio 6c44440 link true /test integ-helm
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 14, 2025
@dhawton
Copy link
Copy Markdown
Member

dhawton commented Jun 16, 2025

/test integ-cni

@istio-testing istio-testing merged commit ff171dd into istio:release-1.26 Jun 16, 2025
29 of 57 checks passed
@howardjohn howardjohn mentioned this pull request Aug 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhawton dhawton dhawton approved these changes

@grnmeira grnmeira grnmeira approved these changes

@costinm costinm Awaiting requested review from costinm

@linsun linsun Awaiting requested review from linsun

@stevenctl stevenctl Awaiting requested review from stevenctl

@keithmattix keithmattix Awaiting requested review from keithmattix

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

Assignees

No one assigned

Labels

release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[release-1.26] krt: add assertions

4 participants

@howardjohn @istio-testing @dhawton @grnmeira