Skip to content

fix: update scenario 5 to only provide a single instruction for the expected failure#58

Merged
tritone merged 2 commits intogoogleapis:masterfrom
BenWhitehead:scenario-6-cleanup
Sep 8, 2021
Merged

fix: update scenario 5 to only provide a single instruction for the expected failure#58
tritone merged 2 commits intogoogleapis:masterfrom
BenWhitehead:scenario-6-cleanup

Conversation

@BenWhitehead
Copy link
Copy Markdown
Collaborator

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2021
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2021
@BenWhitehead BenWhitehead changed the title fix: update scenario 6 to only provide a single instruction for the expected failure fix: update scenario 5 to only provide a single instruction for the expected failure Sep 8, 2021
Copy link
Copy Markdown
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tritone tritone merged commit 32a2fd4 into googleapis:master Sep 8, 2021
@BenWhitehead BenWhitehead deleted the scenario-6-cleanup branch September 8, 2021 14:58
BenWhitehead added a commit to googleapis/java-conformance-tests that referenced this pull request Sep 8, 2021
…4ce (#363)

googleapis/conformance-tests@5c25424 chore: rename cloud-storage-dpes to cloud-storage-dpe ([#59](googleapis/conformance-tests#59))
googleapis/conformance-tests@32a2fd4 fix: update scenario 5 to only provide a single instruction for the expected failure ([#58](googleapis/conformance-tests#58))
googleapis/conformance-tests@0fe5931 fix(storage): add methods to s4 non idempotent operations ([#56](googleapis/conformance-tests#56))
googleapis/conformance-tests@64c08de fix(storage): add key resource to HMAC methods that require it ([#54](googleapis/conformance-tests#54))
googleapis/conformance-tests@17650a1 fix(storage): fix typo in method names ([#53](googleapis/conformance-tests#53))

Full diff: googleapis/conformance-tests@37ddc58...5c25424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants