Skip to content

fix(storage): add key resource to HMAC methods that require it#54

Merged
cojenco merged 5 commits intomasterfrom
BrennaEpp-patch-2
Sep 2, 2021
Merged

fix(storage): add key resource to HMAC methods that require it#54
cojenco merged 5 commits intomasterfrom
BrennaEpp-patch-2

Conversation

@BrennaEpp
Copy link
Copy Markdown
Contributor

No description provided.

corrected to line up with the testbench as well as the api
@BrennaEpp BrennaEpp requested a review from BenWhitehead August 27, 2021 23:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 27, 2021
@BrennaEpp BrennaEpp requested a review from cojenco August 27, 2021 23:24
Copy link
Copy Markdown
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cojenco cojenco merged commit 64c08de into master Sep 2, 2021
@cojenco cojenco deleted the BrennaEpp-patch-2 branch September 2, 2021 19:50
BenWhitehead added a commit to googleapis/java-conformance-tests that referenced this pull request Sep 8, 2021
…4ce (#363)

googleapis/conformance-tests@5c25424 chore: rename cloud-storage-dpes to cloud-storage-dpe ([#59](googleapis/conformance-tests#59))
googleapis/conformance-tests@32a2fd4 fix: update scenario 5 to only provide a single instruction for the expected failure ([#58](googleapis/conformance-tests#58))
googleapis/conformance-tests@0fe5931 fix(storage): add methods to s4 non idempotent operations ([#56](googleapis/conformance-tests#56))
googleapis/conformance-tests@64c08de fix(storage): add key resource to HMAC methods that require it ([#54](googleapis/conformance-tests#54))
googleapis/conformance-tests@17650a1 fix(storage): fix typo in method names ([#53](googleapis/conformance-tests#53))

Full diff: googleapis/conformance-tests@37ddc58...5c25424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants