fix(storage): add key resource to HMAC methods that require it (#54)

BrennaEpp · cojenco · web-flow · commit 64c08de16f52 · 2021-09-02T12:50:03.000-07:00
* fix: fix typo in method names

corrected to line up with the testbench as well as the api

* Add key resource to HMAC methods that require it

* Apply suggestions from code review

Co-authored-by: cojenco &lt;cathyo@google.com&gt;

* Update retry_tests.json

Co-authored-by: cojenco &lt;cathyo@google.com&gt;
diff --git a/storage/v1/retry_tests.json b/storage/v1/retry_tests.json
@@ -26,9 +26,9 @@
         {"name": "storage.buckets.testIamPermissions",    "resources": ["BUCKET"]},
         {"name": "storage.default_object_acl.get",        "resources": ["BUCKET"]},
         {"name": "storage.default_object_acl.list",       "resources": ["BUCKET"]},
-        {"name": "storage.hmacKey.delete",                "resources": []},
-        {"name": "storage.hmacKey.get",                   "resources": []},
-        {"name": "storage.hmacKey.list",                  "resources": []},
+        {"name": "storage.hmacKey.delete",                "resources": ["HMAC_KEY"]},
+        {"name": "storage.hmacKey.get",                   "resources": ["HMAC_KEY"]},
+        {"name": "storage.hmacKey.list",                  "resources": ["HMAC_KEY"]},
         {"name": "storage.notifications.delete",          "resources": ["BUCKET", "NOTIFICATION"]},
         {"name": "storage.notifications.get",             "resources": ["BUCKET", "NOTIFICATION"]},
         {"name": "storage.notifications.list",            "resources": ["BUCKET", "NOTIFICATION"]},
@@ -59,7 +59,7 @@
         {"name": "storage.buckets.patch",         "resources": ["BUCKET"]},
         {"name": "storage.buckets.setIamPolicy",  "resources": ["BUCKET"]},
         {"name": "storage.buckets.update",        "resources": ["BUCKET"]},
-        {"name": "storage.hmacKey.update",        "resources": []},
+        {"name": "storage.hmacKey.update",        "resources": ["HMAC_KEY"]},
         {"name": "storage.objects.compose",       "resources": ["BUCKET", "OBJECT"]},
         {"name": "storage.objects.copy",          "resources": ["BUCKET", "OBJECT"]},
         {"name": "storage.objects.delete",        "resources": ["BUCKET", "OBJECT"]},
@@ -89,7 +89,7 @@
         {"name": "storage.buckets.patch",         "resources": ["BUCKET"]},
         {"name": "storage.buckets.setIamPolicy",  "resources": ["BUCKET"]},
         {"name": "storage.buckets.update",        "resources": ["BUCKET"]},
-        {"name": "storage.hmacKey.update",        "resources": []},
+        {"name": "storage.hmacKey.update",        "resources": ["HMAC_KEY"]},
         {"name": "storage.objects.compose",       "resources": ["BUCKET", "OBJECT"]},
         {"name": "storage.objects.copy",          "resources": ["BUCKET", "OBJECT"]},
         {"name": "storage.objects.delete",        "resources": ["BUCKET", "OBJECT"]},
@@ -149,10 +149,10 @@
         {"name": "storage.default_object_acl.patch",      "resources": ["BUCKET"]},
         {"name": "storage.default_object_acl.update",     "resources": ["BUCKET"]},
         {"name": "storage.hmacKey.create",                "resources": []},
-        {"name": "storage.hmacKey.delete",                "resources": []},
-        {"name": "storage.hmacKey.get",                   "resources": []},
-        {"name": "storage.hmacKey.list",                  "resources": []},
-        {"name": "storage.hmacKey.update",                "resources": []},
+        {"name": "storage.hmacKey.delete",                "resources": ["HMAC_KEY"]},
+        {"name": "storage.hmacKey.get",                   "resources": ["HMAC_KEY"]},
+        {"name": "storage.hmacKey.list",                  "resources": ["HMAC_KEY"]},
+        {"name": "storage.hmacKey.update",                "resources": ["HMAC_KEY"]},
         {"name": "storage.notifications.delete",          "resources": ["BUCKET", "NOTIFICATION"]},
         {"name": "storage.notifications.get",             "resources": ["BUCKET", "NOTIFICATION"]},
         {"name": "storage.notifications.insert",          "resources": ["BUCKET", "NOTIFICATION"]},
